Skip to content

Commit

Permalink
Add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vrabaud committed Aug 28, 2024
1 parent 8969bb4 commit e06232e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/actions/setup-common/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
description: 'Can take the values: OFF, LOCAL, SYSTEM'
default: 'OFF'
oldest-cmake:
description: 'Can take the values: true, false. Only useful on Linux'
description: 'Can take the values: true, false. Only useful on Linux to force using the minimum required CMake'
default: 'false'
runs:
using: "composite"
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci-unix-shared-installed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,19 @@ jobs:
build-shared-installed:
strategy:
fail-fast: false
# Generate the configurations:
# Ubuntu with gcc 14 with oldest-cmake set to true or false
# OSX with default gcc and CMake (oldest-cmake is unused on OSX)
matrix:
os: [ubuntu-24.04, macos-latest]
oldest-cmake: [false, true]
include:
# Add a gcc version on Ubuntu only
- os: ubuntu-24.04
compiler: gcc
gcc: 14
exclude:
# Do not use the oldest CMake on OSX
- os: macos-latest
oldest-cmake: true
runs-on: ${{ matrix.os }}
Expand Down

0 comments on commit e06232e

Please sign in to comment.