Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem issue in avifParseColourInformationBox() #1103

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Fix mem issue in avifParseColourInformationBox() #1103

merged 3 commits into from
Sep 14, 2022

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Sep 12, 2022

See #1086.

jzern
jzern reviewed Sep 12, 2022
View reviewed changes
src/read.c Show resolved Hide resolved
jzern
jzern approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@jzern jzern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ok assuming the offsets are correct

wantehchang
wantehchang approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggested changes. Good job tracking this memory error down.

src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Show resolved Hide resolved
@y-guyon y-guyon merged commit d5859e3 into AOMediaCodec:main Sep 14, 2022
@y-guyon y-guyon deleted the fix_icc_heap_use_after_free branch September 18, 2022 12:05
@wantehchang wantehchang mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzern jzern jzern approved these changes

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-guyon @jzern @wantehchang