avifRWDataRealloc,avifRWDataSet return avifResult #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avifImageSetProfileICC(), avifImageSetMetadataExif(), avifImageSetMetadataXMP() and avifCodecEncodeOutputAddSample(). To catch out-of-memory issues. Bug: AOMediaCodec#820
wantehchang
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Yannis: Thank you very much for writing this pull request. This is something we need to complete before declaring the API as stable (i.e., version 1.0.0).
I have some suggested changes. Please read my comments in rawdata.c first (about the alternative in avifRWDataRealloc()).
Free resources in aviftest.c. Change TODO syntax to match style guide.
Also avifImageSetMetadataExif(), avifImageSetMetadataXMP() and avifCodecEncodeOutputAddSample().
wantehchang
approved these changes
Jul 28, 2023
wantehchang
reviewed
Jul 28, 2023
and avifImageSetProfileICC() even with NULL arg.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
avifImageSetProfileICC(),avifImageSetMetadataExif(),avifImageSetMetadataXMP()andavifCodecEncodeOutputAddSample(). To catch out-of-memory issues.Bug: #820
Suggested follow-ups:
AVIF_RESULT_OUT_OF_MEMORYto all sites calling a function listed above (not done in this change to keep it at a reasonable size)abort()inmakeRoom()