Rename s to dedupStream in WriteColorProperties() #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
LGTM.
I would also be fine with renaming the first parameter of avifEncoderWriteExtendedColorProperties() as s. It was just a little odd to see that avifRWStream variable change name as it crosses function boundaries.
It may be better to add comments to explain dedupStream vs. outputStream...
Done. |
wantehchang
approved these changes
Aug 17, 2023
src/write.c
Outdated
| @@ -538,6 +538,10 @@ static avifBool avifEncoderDetectChanges(const avifEncoder * encoder, avifEncode | |||
| } | |||
|
|
|||
| // Subset of avifEncoderWriteColorProperties() for the properties clli, pasp, clap, irot, imir. | |||
| // outputStream is the final bitstream that will be output by the libavif encoder API. | |||
| // dedupStream is either equal to outputStream or to dedup->s which is a temporary stream used | |||
There was a problem hiding this comment.
Nit: Add & before dedup->s.
Optional: It might be good to move the new comment closer to avifEncoderWriteColorProperties(), where these variables/parameters are actually used.
wantehchang
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]