Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy_stdio_definitions.lib dep with mingw #1649

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Oct 4, 2023

This fixes #1647

@vrabaud vrabaud requested a review from y-guyon October 4, 2023 08:37
CMakeLists.txt Outdated Show resolved Hide resolved
@vrabaud vrabaud merged commit 575ed4f into AOMediaCodec:main Oct 4, 2023
18 checks passed
@vrabaud vrabaud deleted the deps branch October 4, 2023 09:55
@fdintino
Copy link
Contributor

fdintino commented Oct 4, 2023

It looks like the only library I actually needed was advapi32.lib. My build fails after these changes (action run here) with the error:

avif.lib(std-43ecf4bdbb5e1e31.std.221f24cf-cgu.0.rcgu.o) : error LNK2001: unresolved external symbol __imp_OpenProcessToken
avif.lib(std-43ecf4bdbb5e1e31.std.221f24cf-cgu.0.rcgu.o) : error LNK2001: unresolved external symbol __imp_SystemFunction036
build\lib.win-amd64-cpython-39\PIL\_avif.cp39-win_amd64.pyd : fatal error LNK1120: 2 unresolved externals

Both of those symbols are in advapi32. Was its inclusion causing issues?

@wantehchang
Copy link
Collaborator

Frankie: Sorry about that. The inclusion of advapi32.lib did not cause problems, but it didn't seem necessary for two reasons:

  • We didn't need it before, and
  • The "Check static link bundling" step in .github/workflows/ci-windows.yml still passes without it.

We will be happy to add it back. But do you know why the "Check static link bundling" step you added cannot detect this problem?

@fdintino
Copy link
Contributor

fdintino commented Oct 4, 2023

Yes. I think this is actually a problem with the windows static library from the rav1e release; I am using that in my build script whereas here rav1e is being built locally. I'll investigate further and report back.

@wantehchang
Copy link
Collaborator

Frankie: Thanks. We will wait for your report. Also, it would be good to figure out how to make "Check static link bundling" step in .github/workflows/ci-windows.yml reproduce this linker error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mingw-w64: legacy_stdio_definitions.lib does not exist
4 participants