avifenc: Allow large images to be encoded #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
commented
Jul 16, 2024
There was a problem hiding this comment.
Yannis: Please review this pull request carefully. I remember you added the imageSizeLimit parameter to avifReadImage() to avoid out-of-memory errors in fuzzing tests. Also, avifReadImage() passes that parameter to avifJPEGRead() as the sizeLimit parameter, which is also used to limit the size of Exif and XMP metadata. So I don't fully understand the implications of this pull request.
y-guyon
approved these changes
Jul 16, 2024
wantehchang
commented
Jul 17, 2024
y-guyon
approved these changes
Jul 18, 2024
Pass UINT32_MAX as the imageSizeLimit argument to avifReadImage(). Bug: AOMediaCodec#2271
wantehchang
force-pushed
the
avifenc-input-image-size-limit
branch
from
43f599f
to
7e994f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass UINT32_MAX as the imageSizeLimit argument to avifReadImage().
Bug: #2271