Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avifpng.c: Fix overflows in multiply with rowBytes #2285

Conversation

wantehchang
Copy link
Collaborator

Replace multiplication with rgb.rowBytes with addition of rgb.rowBytes to a row pointer in a loop.

Related to #2271.

Replace multiplication with rgb.rowBytes with addition of rgb.rowBytes
to a row pointer in a loop.

Related to AOMediaCodec#2271.
Copy link
Collaborator Author

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am giving you one file to review at a time. This file is the easiest.

@y-guyon
Copy link
Collaborator

y-guyon commented Jul 18, 2024

Should there be a CHANGELOG entry?

@vrabaud vrabaud added this to the v1.1.1 milestone Jul 25, 2024
@wantehchang
Copy link
Collaborator Author

Yannis: I didn't add a CHANGELOG entry because this is just a partial fix for #2271.

@wantehchang wantehchang merged commit 227293d into AOMediaCodec:main Jul 26, 2024
14 checks passed
@wantehchang wantehchang deleted the multiply-row-bytes-in-size-t-avifpng-c branch July 26, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants