-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix out-of-order dimg grid associations #2312
Conversation
b74310c
to
90e9bfa
Compare
Note that the current implementation may not be as optimal as it could be for the following scenario:
This only concerns the unlikely out-of-order |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will take a look at the rest of the PR in a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yannis: Here is my first round of review. I saved some style/preference comments for the next round. I did not review the new avifdimgtest.cc file, but I reviewed the changes to read.c carefully.
Please check my first comment in read.c (marked with "IMPORTANT") carefully. If I am right, this pull request needs more work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Please evaluate the optional suggestions and only accept the ones you agree with. There are two important changes that should be made.
Fixes #2311.
A simpler alternative would have been to refuse to decode out-of-order
dimg
associations.