Make it easier to build android_jni #2475
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for the pull request: could please also have a look at our CI files to see if they have the proper versions? Thx. https://github.com/AOMediaCodec/libavif/blob/main/.github/workflows/ci-android-jni.yml and https://github.com/AOMediaCodec/libavif/blob/main/.github/workflows/ci-android-emulator-tests.yml |
Yeah, they're all fine as it is. |
vigneshvg
reviewed
Oct 14, 2024
vigneshvg
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
targetSdkandcompileSdkto31, alongside with fixing thecpufeatureslibrary on the CMake file for Android builds, to fix the build errors. The PR has also added a recommended NDK revison, asr26and above is causing ani686-linux-android19-clang not founderror from theext/dav1d_android.shbuildscript because support for Android API 19 and 20 was removed.