-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Adding ability to provide a img_tile found in cartopy.io.img_tiles. #728
Conversation
zssherman
commented
Oct 10, 2023
•
edited
Loading
edited
- Closes Sunset Stamen maps in GeoDisplay and potentially replace #727
- Tests added
- Documentation reflects changes
- PEP8 Standards or use of linter
- Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming
Hmm, test plot doesn't have the track, but locally it does... |
Fixed. |
@zssherman would we want to keep the Stamen keyword so we don't break anything and raise a warning that it is deprecated and will no longer be used? |
@AdamTheisen Ah yep good point! I can add the parameter back in and feed it into the new code |
@AdamTheisen I added the warning, let me know how it looks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zssherman it looks like the Stamen cease to work at the end of October. We should plan to test out and maybe update/do a new release then to fully remove it.
@AdamTheisen So a release right before the end of October to remove? |
@zssherman that was my thinking. Deprecation warning now and then removal when it stops working. Open to thoughts thought |
@AdamTheisen That sounds good to me! |