Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adding ability to provide a img_tile found in cartopy.io.img_tiles. #728

Merged
merged 7 commits into from
Oct 12, 2023

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Oct 10, 2023

@zssherman
Copy link
Collaborator Author

Hmm, test plot doesn't have the track, but locally it does...

@zssherman
Copy link
Collaborator Author

Fixed.

@AdamTheisen
Copy link
Collaborator

@zssherman would we want to keep the Stamen keyword so we don't break anything and raise a warning that it is deprecated and will no longer be used?

@zssherman
Copy link
Collaborator Author

@AdamTheisen Ah yep good point! I can add the parameter back in and feed it into the new code

@zssherman
Copy link
Collaborator Author

@AdamTheisen I added the warning, let me know how it looks

Copy link
Collaborator

@AdamTheisen AdamTheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zssherman it looks like the Stamen cease to work at the end of October. We should plan to test out and maybe update/do a new release then to fully remove it.

@zssherman
Copy link
Collaborator Author

@AdamTheisen So a release right before the end of October to remove?

@AdamTheisen
Copy link
Collaborator

@zssherman that was my thinking. Deprecation warning now and then removal when it stops working. Open to thoughts thought

@zssherman
Copy link
Collaborator Author

@AdamTheisen That sounds good to me!

@zssherman zssherman merged commit 573cdaf into ARM-DOE:main Oct 12, 2023
16 checks passed
@zssherman zssherman deleted the img_tiles branch November 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunset Stamen maps in GeoDisplay and potentially replace
2 participants