This repository has been archived by the owner on Apr 24, 2019. It is now read-only.
Fix irq contexts #31
Merged
Fix irq contexts #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During debugging, the tr_debug call in M2MConnectionHandlerPimpl::socket_event took an unacceptable amount of time to complete, causing bytes traveling through the serial connections to be dropped. This was unnoticable in lwip's network-socket implementation due to not occuring in an interrupt context, but prevented the esp8266 from working correctly.
Replaced malloc calls in interrupt contexts with allocations from a local memory pool using rtos::MemoryPool
|
rebuild |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve ARMmbed/mbed-os-example-client#75
mbed-client defines
M2MConnectionHandlerPimpl::socket_eventfor handling the event passed through theUDPSocket::attachfunction. Unfortunately, the previous implementation contained both atr_debugcall andmalloccall that were unacceptably long-running and caused UART bytes to be dropped.This issue was not unnoticable in lwip's implementation. We could update lwip to dispatch events in a critical section, insuring correct behaviour, although this would introduce unnecessary jitter in existing code.
moved from ARMmbed/mbed-os#2530
cc @yogpan01, @jupe