Fix iar compilation issues #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to a version of mbed-os-atecc608a that ignores cryptoauthlib's app/api_206a, as we don't need it and it currently doesn't build with IAR.
|
Test run with ARM and IAR compilers: https://jenkins-internal.mbed.com/job/mbed-crypto-release-ci-testing/664/ |
Patater
suggested changes
Feb 24, 2020
| @@ -103,7 +103,7 @@ enum { | |||
| key_bits = 256, | |||
| hash_alg = PSA_ALG_SHA_256, | |||
| alg = PSA_ALG_ECDSA(hash_alg), | |||
| sig_size = PSA_ASYMMETRIC_SIGN_OUTPUT_SIZE(key_type, key_bits, alg), | |||
There was a problem hiding this comment.
In "Set signature size directly", could you copy and paste the error or warning message into the commit message? It'll help to make it more clear why this failed in IAR.
As we know this example is using ECC, set the signature size directly rather than using PSA_ASYMMETRIC_SIGN_OUTPUT_SIZE, as it gives the following error with IAR: Error[Pe184]: type of cast must be arithmetic or pointer
The atCRC function wants crc to be a uint8_t array of length 2, while atcab_lock_config_zone_crc wants crc to be a uint16_t. IAR treats this as an error rather than a warning like ARM and GCC, so handle it explicitly.
dgreen-arm
force-pushed
the
fix-IAR-compilation-issues
branch
from
5b651cd
to
6083393
Compare
Patater
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the atecc608a driver to include a version of cryptoauthlib that supports IAR.
This uncovered a few issues with IAR that this PR also fixes.