App housekeeping + Add support for DISCO_F429ZI and EFM32GG_STK3700 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest uvisor |
AlessandroA
force-pushed
the
apps_housekeeping
branch
5 times, most recently
from
1b4a3c3
to
7381fb5
Compare
Patater
suggested changes
Jun 13, 2017
| @@ -1 +1 @@ | |||
| https://github.com/ARMmbed/mbed-os/#fc1836545dcc2fc86f03b01292b62bf2089f67c3 | |||
| https://github.com/ARMmbed/mbed-os/#92fbf2a9b3988d430482fc25a6077f2462e2a634 | |||
There was a problem hiding this comment.
Please mention what version this is in the commit message.
source/main.cpp
Outdated
| @@ -38,7 +38,7 @@ DigitalOut led_red(LED1); | |||
| DigitalOut led_green(LED2); | |||
| DigitalOut led_blue(LED3); | |||
|
|
|||
| Serial shared_pc(USBTX, USBRX); | |||
| Serial shared_pc(USBTX, USBRX, 115200); | |||
There was a problem hiding this comment.
Please make this commit ("Explicitly set the baud rate for the shared Serial") add SHARED_SERIAL_BAUD to all targets. This commit should come before the adding of new targets commits, so that each new target added will work in the commit it is added.
| client_a: Attempt to write 0xFFFFFC18 (granted) | ||
| public : Attempt to read : 0xFFFFFC18 (granted) | ||
|
|
||
| ***** uVisor secure number store example ***** |
There was a problem hiding this comment.
Remove SHARED_SERIAL_BAUD from the "Update UART log for the CI" commit.
AlessandroA
force-pushed
the
apps_housekeeping
branch
from
7381fb5
to
1b4f574
Compare
Now that mbed OS has been updated, we do not need the backwards compatible guard any more.
* Reduce pages-backed memory, which is not needed by this example. * Increase memory where needed to make sure threads have enough buffer space for printf.
The code snippet added here has been auto-generated by uVisor when running the app in debug mode. The additional reserved space is needed as a result of an ARMv7-M MPU limitation.
This makes it easier to maintain this file across different applications.
To help CI, we want the first messages of the sequence to be predicatble. After the first burst, timing will mix messages up, which is good for the robustness of the app. public box threads.
This helps avoiding confusion when different targets have different baud rate expectation. If we enable the EFM32GG_STK3700 target, for example, it would fail to print if the baud rate was 9600, the default mbed baud rate.
Fixes ARMmbed#19: "mbed-os-example-uvisor-number-store doesn't work on EFM32GG_STK3700"
Fixes ARMmbed#18: "mbed-os-example-uvisor-number-store doesn't work on DISCO_F429ZI"
AlessandroA
force-pushed
the
apps_housekeeping
branch
from
1b4f574
to
051d8f6
Compare
Patater
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Patater @niklas-arm