Fix ci errors #239
Merged
Fix ci errors #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urutva
force-pushed
the
fix-ci
branch
3 times, most recently
from
8508ba2
to
bf90dbf
Compare
Patater
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Commit message says "Supported python versions are python 3.6, 3.7 and 3.8.", but I think we also support 3.5 and 2.7 for now, as well. Mentioning the supported python version in the commit message that adds 3.8 probably isn't necessary either: keep the message focused on what the commit does and why it does it.
Patater
suggested changes
Oct 14, 2020
The missing package `wheel` is added to `test_requirements.txt`. Signed-off-by: Devaraj Ranganna <[email protected]>
Patater
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wheelPull request type
Reviewers