-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS can break the compilation #2411
Comments
@screamerbg @sg- can you look into this please? |
Thanks for the note. Need to update the includes client and rf driver use. Will resolve this @geky |
ARM Internal Ref: IOTMORF-426 |
The client has had conflicting header files removed for a while, but it unfortunately took a while to move into mainstream mbed-os. I'm unfamiliar with the rf driver and it my have been removed in a previous change. Do the includes still present issues? |
I tried a fresh checkout of mbed-os-example-client and v5.0.5 of sal-stack-nanostack-private Builds, but linking fails.
|
@geky The issue is still valid. The problem does not arise if you are using Nanostack binaries with public release. However, if you are using sources file name conflict will arise in Windows OS. Because Windows is case insensitive. Javier explained it very well above. We changed the atmel-rf-driver to include rots.h instead of Thread.h, Mutex.h and namespace mbed. |
This shouldn't be the case. mbed.h (rtos.h included by mbed.h) is the entry point and should use path referenced includes. If this is not the case, please open an issue for that. Its not clear here what you're saying the problem is. |
@kjbracey-arm Can you please explain here what we saw while compiling with Nanostack sources ? |
@javier-moreno-tridonic-com it sounds like the main function is missing. The original issue is confirmed to be resolved. If there is a different issue, please open it with steps to reproduce. |
Trying to resolve this issue and thanks to @hasnainvirk we saw that when compiling some examples, the #include directives resolution has different behaviours in linux and windows. This is mainly caused by names that will be considered as different by linux and not by windows.
For instance the file thread.h that is part of the sal-stack-nanostack-private source and Thread.h included in mbed-os source.
@MarceloSalazar @markus-becker-tridonic-com
The text was updated successfully, but these errors were encountered: