Cypress Cordio BT Driver setting Host MCU active during Host Wake assert #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve for the duration BT device asserts HOST WAKE. This change fixes race condition in Cypress Cordio driver.
|
@MukundGitHub, thank you for your changes. |
|
@pan- @donatieng please review |
0xc0170
approved these changes
Oct 14, 2019
pan-
requested changes
Oct 16, 2019
| @@ -93,6 +94,7 @@ class CyH4TransportDriver : public cordio::CordioHCITransportDriver { | |||
|
|
|||
| DigitalInOut bt_host_wake; | |||
| DigitalInOut bt_device_wake; | |||
| bool bt_host_wake_active; | |||
There was a problem hiding this comment.
This value should be initialised in the constructor.
There was a problem hiding this comment.
Thanks for review feedback. Addressed the feedback with new commit. Please review the changes and approve the PR Merge request.
|
For future reference, rather than "Address ARM Code review feedback.", just specify what has changed. When we get back to this few days later no one will remember what feedback was it. |
|
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
MukundGitHub
deleted the
cypress_cordio_driver_host_wake_logic_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Target Cypress Specific Cordio BT Driver to keep Host MCU active for the duration BT device asserts HOST WAKE. This change fixes race condition in Cypress Cordio driver.
Change Description:
1) Added Rising and falling edge interrupt for Host Wake Pin
2) Keep Host MCU active for the duration of Host Wake Pin Asserted
3) Remove Cordio inactivity virtual functions
Tested with mbed os BT applications:
1) mbed-os-example-ble-LED
2) mbed-os-example-ble-Beacon
Pull request type
Reviewers
Release Notes