Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress: Remove qspi_frequency() call. #12038

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Cypress: Remove qspi_frequency() call. #12038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion targets/TARGET_Cypress/TARGET_PSOC6/cy_qspi_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ qspi_status_t qspi_free(qspi_t *obj)

qspi_status_t qspi_frequency(qspi_t *obj, int hz)
{
return CY_RSLT_SUCCESS == cyhal_qspi_set_frequency(&(obj->hal_qspi), (uint32_t)hz) ? QSPI_STATUS_OK : QSPI_STATUS_ERROR;
/* Return OK since this API is not implemented in cy_hal */
return QSPI_STATUS_OK;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QSPI_STATUS_ERROR here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS/mbed_hal/qspi/main.cpp line 261 will fail:
ret = qspi_frequency(&qspi.handle, frequency);

What should we do in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this function should always return TRUE as it should be implemented 🙄

Lets leave it as it is, this should get fixed once we have capabilities

}

static inline cyhal_qspi_bus_width_t cyhal_qspi_convert_width(qspi_bus_width_t width)
Expand Down