Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM: move us_ticker_defines.h include #13090

Merged
merged 1 commit into from
Jun 10, 2020
Merged

STM: move us_ticker_defines.h include #13090

merged 1 commit into from
Jun 10, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix #12990

"us_ticker_defines.h" include was strangely set in device.h file

@pilotak

Impact of changes

none

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team June 9, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 9, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Jun 10, 2020

Command refresh: success

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten.

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 10, 2020
@0xc0170 0xc0170 merged commit 878875c into ARMmbed:master Jun 10, 2020
@mergify mergify bot removed the ready for merge label Jun 10, 2020
@jeromecoutant jeromecoutant deleted the PR_DEVICE_H branch June 10, 2020 09:56
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
This was referenced Apr 13, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STM32 target inherit: US_TICKER_MASK not defined
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @adbridge