-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CYSBSYSKIT_01 #13416
Update CYSBSYSKIT_01 #13416
Conversation
@dustin-crossman, thank you for your changes. |
Please review travis failures, related to the target (missing sectors). |
@dustin-crossman please note, target updates are not features . Unless you are changing an mbed-os api etc then these should be patches. Also considering code freeze is tomorrow, this has landed a little late...One futher point, you cannot assume what the next release version will be as the version is determined by the content which has landed by the time we hit code freeze. Could you please update the PR title accordingly. Thanks. |
@adbridge Good point on the versioning. Title and PR type updated. |
@dustin-crossman if you can resolve failures in tools today, we can restart CI and get this in for the upcoming release (code freeze today) |
@0xc0170 Sectors info added in! Hopefully that resolves the CI failures. |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@dustin-crossman test passed but travis did not, can you verify? |
I restarted. sectors are present in target.json, I am not seeing why it would assert now :/ |
@dustin-crossman We would like to code freeze the next release today. Shall we postpone this to the next one? |
cc @ARMmbed/team-cypress ^^ |
I think it wants the sectors to be in the tools/arm_pack_manager/index.json instead of just the targets.json. Yea lets postpone this to the next one. |
Added sectors info the arm_pack_manager/index.json. Looks like that fixed up the CI issues. |
@0xc0170 Does this look ready to go with the CI issues fixed up? |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Updates COMPONENT_SCL to support WiFi SCAN.
Updates board assets and linker scripts
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
08_06_MCUBoot-mbed-os-6.2.0.txt
Test failure explanations:
Reviewers