Fix trivial compiler Warnings #13476

talorion · 2020-08-22T13:16:02Z

Summary of changes

Fixed some trivial warnings with ARM_GCC and default profile.

Following warnings were fixed:

[Warning] CellularContext.cpp@121,20: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'unsigned int'} [-Wsign-compare]
[Warning] CellularStateMachine.cpp@310,13: format '%d' expects argument of type 'int', but argument 4 has type 'std::chrono::duration<int, std::ratio<1, 1000> >' [-Wformat=]
[Warning] CellularStateMachine.cpp@327,13: format '%d' expects argument of type 'int', but argument 4 has type 'std::chrono::duration<int, std::ratio<1, 1000> >' [-Wformat=]
[Warning] CellularStateMachine.cpp@411,13: format '%d' expects argument of type 'int', but argument 4 has type 'std::chrono::duration<int, std::ratio<1, 1000> >' [-Wformat=]
[Warning] CellularStateMachine.cpp@476,17: format '%d' expects argument of type 'int', but argument 4 has type 'std::chrono::duration<int, std::ratio<1, 1000> >' [-Wformat=]
[Warning] CellularStateMachine.cpp@490,17: format '%d' expects argument of type 'int', but argument 4 has type 'std::chrono::duration<int, std::ratio<1, 1000> >' [-Wformat=]
[Warning] CellularStateMachine.cpp@638,21: format '%d' expects argument of type 'int', but argument 4 has type 'std::chrono::duration<int>' [-Wformat=]
[Warning] QUECTEL_BC95_CellularStack.cpp@228,48: suggest parentheses around '&&' within '||' [-Wparentheses]
[Warning] TELIT_ME310_CellularStack.cpp@69,9: unused variable 'modem_connect_id' [-Wunused-variable]
[Warning] TELIT_ME310_CellularStack.cpp@227,9: unused variable 'modem_connect_id' [-Wunused-variable]
[Warning] TELIT_ME310_CellularStack.cpp@229,9: unused variable 'err' [-Wunused-variable]
[Warning] TELIT_ME310_CellularStack.cpp@402,21: variable 'data_left' set but not used [-Wunused-but-set-variable]
[Warning] TELIT_ME310_CellularStack.cpp@443,34: 'int mbed::TimerBase::read_ms() const' is deprecated: Use the Chrono-based elapsed_time method.  If integer milliseconds are needed, you can use `duration_cast<milliseconds>(elapsed_time()).count()` [since mbed-os-6.0.0] [-Wdeprecated-declarations]
[Warning] UBLOX_AT_CellularStack.cpp@172,13: unused variable 'ch' [-Wunused-variable]
[Warning] UBLOX_AT_CellularStack.cpp@375,53: comparison of integer expressions of different signedness: 'unsigned int' and 'intptr_t' {aka 'int'} [-Wsign-compare]
[Warning] ppp_service_if.cpp@520,124: 'int events::EventQueue::call_in(int, F) [with F = mbed::Callback<void()>]' is deprecated: Pass a chrono duration, not an integer millisecond count. For example use `5s` rather than `5000`. [since mbed-os-6.0.0] [-Wdeprecated-declarations]
[Warning] ppp_service.cpp@361,74: 'bool rtos::Semaphore::try_acquire_for(uint32_t)' is deprecated: Pass a chrono duration, not an integer millisecond count. For example use `5s` rather than `5000`. [since mbed-os-6.0.0] [-Wdeprecated-declarations]
[Warning] tcp.c@86,20: 'trace_tcp_flags' defined but not used [-Wunused-function]
[Warning] nsapi_dns.cpp@51,24: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
[Warning] nsapi_dns.cpp@492,28: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
[Warning] nsapi_dns.cpp@51,24: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
[Warning] SFDP.cpp@409,22: comparison of integer expressions of different signedness: 'long long unsigned int' and 'int' [-Wsign-compare]

Impact of changes

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2020-08-22T13:30:32Z

@talorion, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

ladislas · 2020-08-24T07:22:53Z

Nice! wanted to do the same :)

talorion · 2020-08-24T08:38:07Z

https://github.com/orgs/ARMmbed/teams/mbed-os-maintainers :
continuous-integration/travis-ci/pr has the error The program 'arm-none-eabi-gcc' is currently not installed. To run 'arm-none-eabi-gcc' please ask your administrator to install the package 'gcc-arm-none-eabi'.
since none of my changes touch the tools or the setup of the containers i don't think this is related to my PR

0xc0170 · 2020-08-24T09:41:38Z

@talorion Would you be able to rebase on the latest master?

…ness

talorion · 2020-08-24T11:18:32Z

@talorion Would you be able to rebase on the latest master?

@0xc0170 i did rebase to the latest master still the same problem

0xc0170 · 2020-08-24T12:37:56Z

@talorion Can you please rebase, the history looks incorrect (bad rebase?)

0xc0170 · 2020-08-24T12:38:49Z

Thanks for fixing these warnings 👍 I'll review once the history is correct (to make sure I am not reviewing unrelated changes).

0xc0170

It needs rebase as requested above

Pull request has been modified.

…for(uint32_t)

…ness

…Stack.cpp Co-authored-by: Hugues Kamba <[email protected]>

kjbracey · 2020-08-27T16:30:14Z

connectivity/drivers/cellular/TELIT/ME310/TELIT_ME310_CellularStack.cpp

@@ -440,7 +440,7 @@ nsapi_size_or_error_t TELIT_ME310_CellularStack::socket_recvfrom_impl(CellularSo
                // read() should not fail
                success = false;
            }
-        } else if (timer.read_ms() < ME310_SOCKET_TIMEOUT) {
+        } else if (std::chrono::duration_cast<std::chrono::milliseconds>(timer.elapsed_time()) < socket_timeout) {


The duration cast is not required here. You only need it when doing a precision-losing conversion.

Comparisons are always exact, regardless of the precision on either side. The less-precise thing gets converted to the more-precise thing.

Suggested change

} else if (std::chrono::duration_cast<std::chrono::milliseconds>(timer.elapsed_time()) < socket_timeout) {

} else if (timer.elapsed_time() < socket_timeout) {

i changed it accordingly to your suggestions

kjbracey · 2020-08-27T16:31:17Z

connectivity/drivers/cellular/UBLOX/AT/UBLOX_AT_CellularStack.cpp

@@ -372,7 +371,7 @@ UBLOX_AT_CellularStack::CellularSocket *UBLOX_AT_CellularStack::find_socket(int
 {
    CellularSocket *socket = NULL;

-    for (unsigned int x = 0; (socket == NULL) && (x < _device.get_property(AT_CellularDevice::PROPERTY_SOCKET_COUNT)); x++) {
+    for (intptr_t x = 0; (socket == NULL) && (x < _device.get_property(AT_CellularDevice::PROPERTY_SOCKET_COUNT)); x++) {


intptr_t? That's not what you want here. (It's for storing pointers as integers).

You want size_t or ptrdiff_t, depending on whether you need it to be signed or not.

i changed it accordingly to your suggestions

kjbracey · 2020-08-27T16:32:08Z

connectivity/libraries/ppp/source/ppp_service.cpp

@@ -60,7 +60,7 @@ extern "C" { // "pppos.h" is missing extern C
 /* Timeout to wait for PPP connection to be terminated
 * (LCP Terminate-Request is answered with Terminate-Ack)
 */
-#define PPP_TERMINATION_TIMEOUT           30000
+#define PPP_TERMINATION_TIMEOUT 30s;


This shouldn't work - you don't have a using directive (and it's got a stray semicolon). Not used?

i changed it accordingly to your suggestions

Please take into account Kevin's comment.

…Stack.cpp Co-authored-by: Kevin Bracey <[email protected]>

Co-authored-by: Kevin Bracey <[email protected]>

…ackRfPhyAT86RF215.cpp Co-authored-by: Kevin Bracey <[email protected]>

talorion · 2020-09-03T09:02:16Z

ping

0xc0170 · 2020-09-04T11:01:30Z

CI started

mbed-ci · 2020-09-04T12:08:31Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_wisun-mesh-test	✔️

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 22, 2020

ciarmcom requested review from a team August 22, 2020 13:30

ciarmcom added the needs: review label Aug 22, 2020

talorion added 6 commits August 24, 2020 11:55

fixed warnings: comparison of integer expressions of different signed…

fcb81d3

…ness

fixed warnings: removed unused variables

f90d062

fixed warnings: printf format missmatch

d11ce60

fixed warnings: suggest parentheses around '&&' within '||'

8d1553c

fixed warnings: unused variable

accadee

fixed warnings: comparison of integer expressions of different signed…

ca74659

…ness

0xc0170 previously requested changes Aug 24, 2020

View reviewed changes

mergify bot added needs: work and removed needs: review labels Aug 24, 2020

talorion added 8 commits August 24, 2020 15:34

fixed warnings: deprecated call of events::EventQueue::call_in(int. F)

30e0ff6

fixed warnings: deprecated call of bool rtos::Semaphore::try_acquire_…

c7d520e

…for(uint32_t)

fixed warnings: comparison of integer expressions of different signed…

2a6f006

…ness

fixed warnings: comparison of integer expressions of different signed…

9af18af

…ness

fixed warnings: comparison of integer expressions of different signed…

a721767

…ness

fixed warnings: deprecated call of Timer::read_ms()

f58633c

fixed warnings: static method defined but not used

e3080a6

resolved astyle - coding format.

fa0ab3e

0xc0170 self-requested a review August 24, 2020 15:22

talorion and others added 2 commits August 27, 2020 17:40

Update connectivity/drivers/cellular/TELIT/ME310/TELIT_ME310_Cellular…

65fa697

…Stack.cpp Co-authored-by: Hugues Kamba <[email protected]>

made sslctxID constexpr

6488381

hugueskamba previously approved these changes Aug 27, 2020

View reviewed changes

kjbracey reviewed Aug 27, 2020

View reviewed changes

talorion and others added 3 commits August 27, 2020 21:08

Update connectivity/drivers/cellular/TELIT/ME310/TELIT_ME310_Cellular…

2b4268a

…Stack.cpp Co-authored-by: Kevin Bracey <[email protected]>

Update connectivity/libraries/ppp/source/ppp_service.cpp

6bf4dda

Co-authored-by: Kevin Bracey <[email protected]>

Update connectivity/drivers/802.15.4_RF/atmel-rf-driver/source/Nanost…

c4b93fe

…ackRfPhyAT86RF215.cpp Co-authored-by: Kevin Bracey <[email protected]>

0xc0170 requested review from hugueskamba and kjbracey September 3, 2020 14:15

0xc0170 added needs: review and removed needs: work labels Sep 3, 2020

0xc0170 self-requested a review September 3, 2020 14:15

kjbracey approved these changes Sep 3, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Sep 3, 2020

0xc0170 approved these changes Sep 3, 2020

View reviewed changes

hugueskamba approved these changes Sep 3, 2020

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Sep 4, 2020

0xc0170 merged commit b2ac609 into ARMmbed:master Sep 7, 2020

mergify bot removed the ready for merge label Sep 7, 2020

talorion deleted the bugfix/fix-warnings branch September 7, 2020 12:46

mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix trivial compiler Warnings #13476

Fix trivial compiler Warnings #13476

talorion commented Aug 22, 2020 •

edited by hugueskamba

Loading

ciarmcom commented Aug 22, 2020

ladislas commented Aug 24, 2020

talorion commented Aug 24, 2020 •

edited

Loading

0xc0170 commented Aug 24, 2020

talorion commented Aug 24, 2020

0xc0170 commented Aug 24, 2020

0xc0170 commented Aug 24, 2020

0xc0170 left a comment

kjbracey Aug 27, 2020

talorion Sep 1, 2020

kjbracey Aug 27, 2020

talorion Sep 1, 2020

kjbracey Aug 27, 2020

talorion Sep 1, 2020

talorion commented Sep 3, 2020

0xc0170 commented Sep 4, 2020

mbed-ci commented Sep 4, 2020

	} else if (std::chrono::duration_cast<std::chrono::milliseconds>(timer.elapsed_time()) < socket_timeout) {
	} else if (timer.elapsed_time() < socket_timeout) {

Fix trivial compiler Warnings #13476

Fix trivial compiler Warnings #13476

Conversation

talorion commented Aug 22, 2020 • edited by hugueskamba Loading

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

ciarmcom commented Aug 22, 2020

ladislas commented Aug 24, 2020

talorion commented Aug 24, 2020 • edited Loading

0xc0170 commented Aug 24, 2020

talorion commented Aug 24, 2020

0xc0170 commented Aug 24, 2020

0xc0170 commented Aug 24, 2020

0xc0170 left a comment

Choose a reason for hiding this comment

kjbracey Aug 27, 2020

Choose a reason for hiding this comment

talorion Sep 1, 2020

Choose a reason for hiding this comment

kjbracey Aug 27, 2020

Choose a reason for hiding this comment

talorion Sep 1, 2020

Choose a reason for hiding this comment

kjbracey Aug 27, 2020

Choose a reason for hiding this comment

talorion Sep 1, 2020

Choose a reason for hiding this comment

talorion commented Sep 3, 2020

0xc0170 commented Sep 4, 2020

mbed-ci commented Sep 4, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

talorion commented Aug 22, 2020 •

edited by hugueskamba

Loading

talorion commented Aug 24, 2020 •

edited

Loading