Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSID bug on Cypress Targets #13493

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

balajicyp
Copy link
Contributor

Summary of changes

Fix SSID bug on Cypress Targets

This changes is required to fix an issue when SSID length is 32 bytes long then only 31 bytes are copied
into SSID name causing WiFi association failure.

Impact of changes

This change is limited to only Cypress Target boards.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

The fix is tested by changing the SSID length to 32 bytes and checking for WiFi Association. The MBED-OS example is modified
to SSID length of 32 bytes and tested for WiFi Connection and IP address ( https://github.com/ARMmbed/mbed-os-example-wifi)
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR


Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 26, 2020
@ciarmcom
Copy link
Member

@balajicyp, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 26, 2020 01:00
@balajicyp
Copy link
Contributor Author

I have tested using MBED OS wifi example from https://github.com/ARMmbed/mbed-os-example-wifi
changed SSID in mbed_app.json to "abcedfghijklmnopqrstuvwxyzABCDEF" and with this change able to connect to WiFi and get IP address.

LOG

Mbed OS version 6.2.1

Scan:
WLAN MAC Address : C4:AC:59:7B:5D:DC
WLAN Firmware : wl0: Jan 30 2020 21:41:53 version 7.45.98.95 (r724303 CY) FWID 01-5afc8c1e
WLAN CLM : API: 12.2 Data: 9.10.39 Compiler: 1.29.4 ClmImport: 1.36.3 Creation: 2020-01-30 21:30:05
WHD VERSION : v1.91.2 : v1.91.2 : GCC 9.3 : 2020-06-25 02:15:47 -0500
Network: ATT080 secured: Unknown BSSID: C0:A0:D:25:ee:0 RSSI: -53 Ch: 1
Network: ATTkmegea2 secured: Unknown BSSID: C:EA:C9:a2:83:80 RSSI: -82 Ch: 1
Network: ATT4tzf4dx secured: Unknown BSSID: E0:22:4:7c:7b:85 RSSI: -90 Ch: 1
Network: universe secured: Unknown BSSID: 70:4F:57:e2:f2:db RSSI: -88 Ch: 1
Network: Irn Bru secured: Unknown BSSID: 6C:B0:CE:b2:7b:3 RSSI: -71 Ch: 4
Network: NETGEAR45 secured: Unknown BSSID: CC:40:D0:6:6d:16 RSSI: -72 Ch: 6
Network: DIRECT-3F-HP OfficeJet Pro 8720 secured: Unknown BSSID: 18:60:24:e:b8:44 RSSI: -97 Ch: 6
Network: WolfeNet secured: Unknown BSSID: 7E:D2:94:35:e8:35 RSSI: -70 Ch: 6
Network: secured: Unknown BSSID: 12:2:8E:a4:8c:43 RSSI: -78 Ch: 6
Network: WolfeNet secured: Unknown BSSID: E:2:8E:a4:8c:43 RSSI: -81 Ch: 6
Network: abcedfghijklmnopqrstuvwxyzABCDEF secured: Unknown BSSID: 3C:37:86:fb:ed:f7 RSSI: -24 Ch: 7
Network: NETGEAR28 secured: Unknown BSSID: 28:80:88:1c:ce:c2 RSSI: -71 Ch: 10
Network: Home123 secured: Unknown BSSID: C:54:A5:cf:ac:c0 RSSI: -76 Ch: 11
Network: secured: Unknown BSSID: 16:E:83:bf:8f:54 RSSI: -83 Ch: 11
Network: Bobo secured: Unknown BSSID: F4:E:83:bf:8f:54 RSSI: -84 Ch: 11
15 networks available.

Connecting to abcedfghijklmnopqrstuvwxyzABCDEF...
Success

MAC: c4:ac:59:7b:5d:dc
IP: 192.165.100.16
Netmask: 255.255.255.0
Gateway: 192.165.100.1
RSSI: -24

Done

Without Patch getting error below are the LOGS

LOGS without patch

Mbed OS version 6.2.1

Scan:
WLAN MAC Address : C4:AC:59:7B:5D:DC
WLAN Firmware : wl0: Jan 30 2020 21:41:53 version 7.45.98.95 (r724303 CY) FWID 01-5afc8c1e
WLAN CLM : API: 12.2 Data: 9.10.39 Compiler: 1.29.4 ClmImport: 1.36.3 Creation: 2020-01-30 21:30:05
WHD VERSION : v1.91.2 : v1.91.2 : GCC 9.3 : 2020-06-25 02:15:47 -0500
Network: DIRECT-A0-HP OfficeJet 3830 secured: WPA2 BSSID: 38:22:E2:4e:c8:a1 RSSI: -84 Ch: 1
Network: jacky_EXT secured: WEP BSSID: 28:C6:8E:89:c0:20 RSSI: -93 Ch: 1
Network: ATT080 secured: Unknown BSSID: C0:A0:D:25:ee:0 RSSI: -50 Ch: 1
Network: universe secured: Unknown BSSID: 70:4F:57:e2:f2:db RSSI: -82 Ch: 1
Network: secured: Unknown BSSID: 84:16:F9:6d:21:24 RSSI: -83 Ch: 3
Network: Irn Bru secured: Unknown BSSID: 6C:B0:CE:b2:7b:3 RSSI: -68 Ch: 4
Network: HP-Print-DD-Officejet Pro 8600 secured: Unknown BSSID: 44:1E:A1:e9:60:dd RSSI: -92 Ch: 4
Network: NETGEAR45 secured: Unknown BSSID: CC:40:D0:6:6d:16 RSSI: -75 Ch: 6
Network: secured: Unknown BSSID: 12:2:8E:a4:8c:43 RSSI: -74 Ch: 6
Network: WolfeNet secured: Unknown BSSID: 7E:D2:94:35:e8:35 RSSI: -68 Ch: 6
Network: WolfeGuest secured: Unknown BSSID: 86:D2:94:35:e8:35 RSSI: -68 Ch: 6
Network: WolfeNet secured: Unknown BSSID: E:2:8E:a4:8c:43 RSSI: -74 Ch: 6
Network: abcedfghijklmnopqrstuvwxyzABCDEF secured: Unknown BSSID: 3C:37:86:fb:ed:f7 RSSI: -26 Ch: 7
Network: NETGEAR28 secured: Unknown BSSID: 28:80:88:1c:ce:c2 RSSI: -73 Ch: 10
14 networks available.

Connecting to abcedfghijklmnopqrstuvwxyzABCDEF...

Connection error: -3008

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 26, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 31ff368 into ARMmbed:master Aug 31, 2020
@mergify mergify bot removed the ready for merge label Aug 31, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants