Cypress: Rename CY8CKIT_064B0S2_4343W to CY8CKIT064B0S2_4343W #13516

romanjoe · 2020-08-31T19:39:53Z

Summary of changes

This PR addresses issue #13424. Target name for existing CY8CKIT_064B0S2_4343W is changed to CY8CKIT064B0S2_4343W to meet requirement of 20 characters in name.

Impact of changes

Change of target name

Migration actions required

Any CI or automated test environment should use new name CY8CKIT064B0S2_4343W

Documentation

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2020-08-31T20:00:28Z

@romanjoe, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test please review.

romanjoe · 2020-09-01T07:52:03Z

There are some CI fails related to "frozen tools". I'm not familiar with that unfortunately. I checked https://os.mbed.com/blog/entry/Introducing-the-new-Mbed-Tools/ page and assume it is related to mbed-os 6.2+ maintenance, what should i do to make CI pass in this case?

0xc0170

I assume there won't be breakages as the old name was not available to users due to the limit?

0xc0170 · 2020-09-01T09:12:37Z

CI started

0xc0170 · 2020-09-01T09:15:13Z

There are some CI fails related to "frozen tools". I'm not familiar with that unfortunately. I checked https://os.mbed.com/blog/entry/Introducing-the-new-Mbed-Tools/ page and assume it is related to mbed-os 6.2+ maintenance, what should i do to make CI pass in this case?

I read your comment right after my review and noticed Travis failing.
tools/targets/PSOC6.py this is not allowed. This fix as stated in the issue unblocks enabling the target to be Mbed enabled. If this is merged, it won't be propagated to the online compiler. @romanjoe was this considered?

@ARMmbed/mbed-os-tools Please can you review this change?

romanjoe · 2020-09-01T09:33:38Z

There are some CI fails related to "frozen tools". I'm not familiar with that unfortunately. I checked https://os.mbed.com/blog/entry/Introducing-the-new-Mbed-Tools/ page and assume it is related to mbed-os 6.2+ maintenance, what should i do to make CI pass in this case?

I read your comment right after my review and noticed Travis failing.
tools/targets/PSOC6.py this is not allowed. This fix as stated in the issue unblocks enabling the target to be Mbed enabled. If this is merged, it won't be propagated to the online compiler. @romanjoe was this considered?

@ARMmbed/mbed-os-tools Please can you review this change?

Hi Martin,
Thank you for answer. Let me clarify a bit - this fix can be accepted and merged, it would unblock mbed enablement of this target.

This change however, would not be propagated to mbed online compiler, due to "frozen tools" check failure in this PR? Since this target is not yet supported in mbed online compiler i am not sure this is a problem right now.

@ifyall could you please confirm we are okay with not be present in online compiler?

mbed-ci · 2020-09-01T09:53:46Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	❌
jenkins-ci/mbed-os-ci_build-GCC_ARM	❌

romanjoe · 2020-09-01T11:24:24Z

Jenkins CI failed. I have reviewed the cause and assume, that CI configuration may still use CY8CKIT_064B0S2_4343W - old name, instead of new one CY8CKIT064B0S2_4343W. Because of this, cysecuretools init command is not called and thus no policy file found on post build.

mergify · 2020-09-02T11:11:14Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

0xc0170 · 2020-09-02T13:29:38Z

This change however, would not be propagated to mbed online compiler, due to "frozen tools" check failure in this PR? Since this target is not yet supported in mbed online compiler i am not sure this is a problem right now.

Please confirm if this is true (this pull request is addressing an issue with mbed-cli, no online compiler update needed).

maclobdell

As far as I know, the online compiler cannot support this target due to special python package requirement (cysecuretools). In past discussions, Cypress only cares about supporting Mbed CLI.

I double checked that this aligns to the mbed-os-tools repo.

https://github.com/ARMmbed/mbed-os-tools/blob/9879d29212e3304626542182cae1fd5a9359713c/src/mbed_os_tools/detect/platform_database.py#L253

    u'1910': u'CY8CKIT064B0S2_4343W',

So it looks good to me.

romanjoe · 2020-09-03T15:17:14Z

This change however, would not be propagated to mbed online compiler, due to "frozen tools" check failure in this PR? Since this target is not yet supported in mbed online compiler i am not sure this is a problem right now.

Please confirm if this is true (this pull request is addressing an issue with mbed-cli, no online compiler update needed).

I confirm - this PR address mbed-cli.

…0 characters limit

Pull request has been modified.

romanjoe · 2020-09-07T05:27:42Z

PR branch rebased to latest master

0xc0170 · 2020-09-07T13:41:16Z

CI started

mbed-ci · 2020-09-07T14:19:26Z

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-ARM	❌

romanjoe · 2020-09-07T14:33:25Z

CI failed again with similar issue in log - can't find policy file. Could someone please check CI config - if it is actually uses new target name and keys, policies are present in correct place (by default it is mbed-os/targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT064B0S2_4343W/policies, mbed-os/targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT064B0S2_4343W/keys), but can de overwritten from mbed_app.json, using field "policy_file": "%path_to_policy_file%"

it is expected, by default that keys are located level up from policy file location and in folder keys.

Example:

/user/home/policy/policy_single_CM0_CM4.json
/user/home/keys/USERAPP_CM4_KEY_PRIV.pem

"policy_file": "/user/home/policy/policy_single_CM0_CM4.json"

0xc0170 · 2020-09-07T14:37:07Z

I'll talk to the test team now

jamesbeyond · 2020-09-07T15:41:09Z

Hi @romanjoe,
what is the target name in the cysecuretools ? is that have any changes? cy8ckit-064b0s2-4343w
I mean do I still run:

cysecuretools -t cy8ckit-064b0s2-4343w init
or 
cysecuretools -t cy8ckit064b0s2-4343w init

romanjoe · 2020-09-07T20:51:37Z

cysecuretools -t cy8ckit-064b0s2-4343w init

Hi, yes target name in cysecuretools is correct. Did you check if missed files are present on build machine, where CI runs? It is hard for me to understand what went wrong with CI now, because everything worked fine until these changes have been introduced.

Do you use mbed_app.json to override policy file location?

Per this error message
Policy file /builds/ws/mbed-os-ci_build-GCC_ARM@7/examples/mbed-os-example-blinky/policy_single_CM0_CM4.json not found. Aborting.

policy file location is not default.

jamesbeyond · 2020-09-08T09:26:55Z

On CI target name changed, and CI restarted

mbed-ci · 2020-09-08T10:14:00Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

romanjoe · 2020-09-08T10:15:12Z

On CI target name changed, and CI restarted

Okay, great!

Thanks, CI finished successfully now!

jamesbeyond · 2020-09-08T10:48:34Z

On CI target name changed, and CI restarted

Okay, great!

Thanks, CI finished successfully now!

Jenkins CI Passed, thought there still some issue, need to be fixed. if checking the successful log, the Greentea images didn't get build properly. due to the mbed-so folder restructure. will fix it and restart CI again soon.

However, the Travis CI did filed with tools freeze check, @0xc0170 @Patater what shall we do about this? ignore the failure?

jamesbeyond · 2020-09-08T11:12:44Z

CI restarted

mbed-ci · 2020-09-08T11:58:09Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

jamesbeyond · 2020-09-08T12:00:08Z

Now CI log looks much better! I'd Say Jenkins is passed, I'll let you deride what to do with TravisCI

romanjoe · 2020-09-08T12:03:32Z

Now CI log looks much better! I'd Say Jenkins is passed, I'll let you deride what to do with TravisCI

Thanks!

Please check this comment #13516 (review)

this target is not expected to work with online compiler anyways, changes in this PR are targeting mbed-cli, so this issue can be ignored per comments from @maclobdell and @0xc0170 (they both have approved PR)

jamesbeyond · 2020-09-08T12:33:17Z

Now CI log looks much better! I'd Say Jenkins is passed, I'll let you deride what to do with TravisCI

Thanks!

Please check this comment #13516 (review)

this target is not expected to work with online compiler anyways, changes in this PR are targeting mbed-cli, so this issue can be ignored per comments from @maclobdell and @0xc0170 (they both have approved PR)

Thanks, but I think what is failing in Travis is have nothing to do with online compiler. it only have things to do with your PR changed the files inside tools folder, where travis-ci/frozen_tools_check mean to blocking it. @Patater has more details regarding this

MarceloSalazar

Thanks for the changes.

0xc0170 · 2020-09-09T08:47:05Z

Approved by @Patater and @andypowers, I'll merge this now.

mergify bot added the needs: work label Aug 31, 2020

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 31, 2020

ciarmcom requested review from maclobdell and a team August 31, 2020 20:00

ciarmcom added the needs: review label Aug 31, 2020

0xc0170 previously approved these changes Sep 1, 2020

View reviewed changes

0xc0170 removed the needs: review label Sep 1, 2020

maclobdell previously approved these changes Sep 3, 2020

View reviewed changes

Rename CY8CKIT_064B0S2_4343W to CY8CKIT064B0S2_4343W, which fits in 2…

8770780

…0 characters limit

romanjoe force-pushed the pr/064b0s2_rename branch from 94a81fe to 8770780 Compare September 7, 2020 05:26

0xc0170 added needs: review and removed needs: work labels Sep 8, 2020

MarceloSalazar approved these changes Sep 9, 2020

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Sep 9, 2020

0xc0170 approved these changes Sep 9, 2020

View reviewed changes

0xc0170 merged commit 2fe10dd into ARMmbed:master Sep 9, 2020

mergify bot removed the ready for merge label Sep 9, 2020

mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020

ifyall mentioned this pull request Sep 18, 2020

CY8CKIT_064B0S2_4343W target name over 20 char limit, not matching mbed-os-tools #13218

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cypress: Rename CY8CKIT_064B0S2_4343W to CY8CKIT064B0S2_4343W #13516

Cypress: Rename CY8CKIT_064B0S2_4343W to CY8CKIT064B0S2_4343W #13516

romanjoe commented Aug 31, 2020 •

edited

Loading

ciarmcom commented Aug 31, 2020

romanjoe commented Sep 1, 2020

0xc0170 left a comment

0xc0170 commented Sep 1, 2020

0xc0170 commented Sep 1, 2020 •

edited

Loading

romanjoe commented Sep 1, 2020

mbed-ci commented Sep 1, 2020

romanjoe commented Sep 1, 2020 •

edited

Loading

mergify bot commented Sep 2, 2020

0xc0170 commented Sep 2, 2020

maclobdell left a comment

romanjoe commented Sep 3, 2020

romanjoe commented Sep 7, 2020

0xc0170 commented Sep 7, 2020

mbed-ci commented Sep 7, 2020

romanjoe commented Sep 7, 2020

0xc0170 commented Sep 7, 2020

jamesbeyond commented Sep 7, 2020 •

edited

Loading

romanjoe commented Sep 7, 2020 •

edited

Loading

jamesbeyond commented Sep 8, 2020

mbed-ci commented Sep 8, 2020

romanjoe commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

mbed-ci commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

romanjoe commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

MarceloSalazar left a comment

0xc0170 commented Sep 9, 2020

Cypress: Rename CY8CKIT_064B0S2_4343W to CY8CKIT064B0S2_4343W #13516

Cypress: Rename CY8CKIT_064B0S2_4343W to CY8CKIT064B0S2_4343W #13516

Conversation

romanjoe commented Aug 31, 2020 • edited Loading

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

ciarmcom commented Aug 31, 2020

romanjoe commented Sep 1, 2020

0xc0170 left a comment

Choose a reason for hiding this comment

0xc0170 commented Sep 1, 2020

0xc0170 commented Sep 1, 2020 • edited Loading

romanjoe commented Sep 1, 2020

mbed-ci commented Sep 1, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

romanjoe commented Sep 1, 2020 • edited Loading

mergify bot commented Sep 2, 2020

0xc0170 commented Sep 2, 2020

maclobdell left a comment

Choose a reason for hiding this comment

romanjoe commented Sep 3, 2020

romanjoe commented Sep 7, 2020

0xc0170 commented Sep 7, 2020

mbed-ci commented Sep 7, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

romanjoe commented Sep 7, 2020

0xc0170 commented Sep 7, 2020

jamesbeyond commented Sep 7, 2020 • edited Loading

romanjoe commented Sep 7, 2020 • edited Loading

jamesbeyond commented Sep 8, 2020

mbed-ci commented Sep 8, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

romanjoe commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

mbed-ci commented Sep 8, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

jamesbeyond commented Sep 8, 2020

romanjoe commented Sep 8, 2020

jamesbeyond commented Sep 8, 2020

MarceloSalazar left a comment

Choose a reason for hiding this comment

0xc0170 commented Sep 9, 2020

romanjoe commented Aug 31, 2020 •

edited

Loading

0xc0170 commented Sep 1, 2020 •

edited

Loading

romanjoe commented Sep 1, 2020 •

edited

Loading

jamesbeyond commented Sep 7, 2020 •

edited

Loading

romanjoe commented Sep 7, 2020 •

edited

Loading