Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-wisun] RADIUS shared secret .json parameter set correction #13517

Merged
merged 1 commit into from
Sep 2, 2020
Merged

[feature-wisun] RADIUS shared secret .json parameter set correction #13517

merged 1 commit into from
Sep 2, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

This pull request corrects configuration error that occurs if WisunBorderRouter class is created before Nanostack mesh system (especially dynamic memory system) is initialized by calling mesh_system_init(). On that situation, Nanostack cannot yet store the .json configuration for RADIUS shared secret and WisunBorderRouter has to do it. Without the correction, RADIUS shared secret and address are not configured correctly from .json configuration and RADIUS interface is not taken into use.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin

@ciarmcom
Copy link
Member

ciarmcom commented Sep 1, 2020

@mikaleppanen, thank you for your changes.
@mikter @artokin @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 1, 2020

Please review astyle failures

@mergify mergify bot added needs: CI and removed needs: work labels Sep 1, 2020
@mikaleppanen
Copy link
Author

@0xc0170 astyle corrected, this can be tested on ci.

@artokin artokin changed the title RADIUS shared secret .json parameter set correction [feature-wisun] RADIUS shared secret .json parameter set correction Sep 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants