Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for a custom cert in connectivity-netsocket-netsocket-tls #13518

Merged
merged 1 commit into from
Sep 9, 2020
Merged

add option for a custom cert in connectivity-netsocket-netsocket-tls #13518

merged 1 commit into from
Sep 9, 2020

Conversation

talorion
Copy link
Contributor

@talorion talorion commented Sep 1, 2020

Test update: add option for custom cert in tls tests

Summary of changes

to be able to set a custom cert in the tests
mbed-os-connectivity-netsocket-tests-tests-netsocket-tls
i added an option to use a custom_certs.h file

Impact of changes

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 1, 2020
@ciarmcom
Copy link
Member

ciarmcom commented Sep 1, 2020

@talorion, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 1, 2020 07:30
@0xc0170 0xc0170 requested a review from a team September 1, 2020 07:48
@mergify mergify bot added needs: CI and removed needs: review labels Sep 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 8, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 8, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit ef43cb5 into ARMmbed:master Sep 9, 2020
@mergify mergify bot removed the ready for merge label Sep 9, 2020
@talorion talorion deleted the feature-custom-cert-tls-tests branch September 9, 2020 09:35
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants