Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_management.py supports application access keys #13524

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

norbert-david
Copy link
Contributor

Summary of changes

The Mbed CLI tool fails to initialize with application access keys. This PR changes the device_management.py so that it works with the new access keys as the legacy API key feature is now deprecated in Pelion Device Management.

Impact of changes

The init script still works with legacy API keys.

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 2, 2020
@ciarmcom ciarmcom requested review from a team September 2, 2020 06:00
@ciarmcom
Copy link
Member

ciarmcom commented Sep 2, 2020

@norbert-david, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to work with both API-keys (ak1_xx) and Application keys (ak2_xx).

@mergify mergify bot added needs: CI and removed needs: review labels Sep 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit f4536be into ARMmbed:master Sep 3, 2020
@mergify mergify bot removed the ready for merge label Sep 3, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants