Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device_management.py supports application access keys 5.15 #13525

Merged
merged 1 commit into from
Oct 13, 2020
Merged

device_management.py supports application access keys 5.15 #13525

merged 1 commit into from
Oct 13, 2020

Conversation

norbert-david
Copy link
Contributor

Summary of changes

The Mbed CLI tool fails to initialize with application access keys. This PR changes the device_management.py so that it works with the new access keys as the legacy API key feature is now deprecated in Pelion Device Management.

Impact of changes

The init script still works with legacy API keys.

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

teetak01
teetak01 approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to work with both API-keys (ak1_xx) and Application keys (ak2_xx).

@mergify mergify bot added the needs: CI label Sep 2, 2020
@mbed-ci
Copy link

mbed-ci commented Sep 2, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

andypowers
andypowers approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 50fe6ac into ARMmbed:mbed-os-5.15 Oct 13, 2020
@mergify mergify bot removed the ready for merge label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@teetak01 teetak01 teetak01 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@norbert-david @mbed-ci @0xc0170 @teetak01 @andypowers