[feature-wisun] Added configuration for RADIUS retry timer to WisunBorderRouter #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikaleppanen, thank you for your changes. |
mikter
reviewed
Sep 2, 2020
|
|
||
| mesh_error_t WisunBorderRouter::set_bbr_radius_timing(void) | ||
| { | ||
| int status = ws_bbr_radius_timing_set(_mesh_if_id, (bbr_radius_timing_t *) &_radius_timing); |
There was a problem hiding this comment.
If this structure is modified having the same structure in both interface makes changing of it quite hard
There was a problem hiding this comment.
Yes, true. I removed the dependency.
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
|
I'll rebase this. |
|
rebased |
artokin
previously approved these changes
Sep 2, 2020
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
|
rebased |
mergify
bot
dismissed
artokin’s stale review
Pull request has been modified.
artokin
approved these changes
Sep 3, 2020
mikter
approved these changes
Sep 3, 2020
|
CI started |
0xc0170
approved these changes
Sep 3, 2020
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This was referenced Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added RADIUS client retry trickle timer configuration interface and .json configuration options to WisunBorderRouter class. Interface can be used to set how fast the RADIUS client retries Access-Request messages to RADIUS server in case reply from server is not received.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@mikter @artokin