Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuvoton: Fix degrading QSPI to SPI (5.15) #13537

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Nuvoton: Fix degrading QSPI to SPI (5.15) #13537

merged 1 commit into from
Sep 7, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Sep 3, 2020

Summary of changes

Same as #13536 but backport to mbed-os 5.15, this PR tries to fix logic with degrading QSPI to SPI. In most cases, we can control degraded QSPI H/W to standard through BSP SPI driver directly as if it is just SPI H/W. However, BSP SPI driver distinguishes among SPI H/W instances in functions:

  • SPI_Open
  • SPI_Close
  • SPI_SetBusClock
  • SPI_GetBusClock

In these cases, we must change to QSPI version instead for QSPI H/W.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
Nuvoton: Fix degrading QSPI to SPI
9c86871 
In most cases, we can control degraded QSPI H/W to standard through BSP SPI driver directly as if it is just SPI H/W.
However, BSP SPI driver distinguishes among SPI H/W instances in below functions:
-   SPI_Open
-   SPI_Close
-   SPI_SetBusClock
-   SPI_GetBusClock
In these cases, we must change to QSPI version instead for QSPI H/W.

Change target:
-   NU_M2354*
@ciarmcom ciarmcom requested a review from a team September 3, 2020 04:30
@ciarmcom
Copy link
Member

ciarmcom commented Sep 3, 2020

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

andypowers
andypowers approved these changes Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 0445b6a into ARMmbed:mbed-os-5.15 Sep 7, 2020
@mergify mergify bot removed the ready for merge label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @andypowers