Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for linker issue in AdBun-M066 #13578

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix for linker issue in AdBun-M066 #13578

merged 1 commit into from
Sep 29, 2020

Conversation

deepak-shreshti
Copy link
Contributor

Summary of changes

Linker issue:
The hardcoded __initial_sp from the startup file of AdBun-M066 (startup_TMPM066.S) has been removed.
The initial stack pointer value ARM_LIB_STACK has been imported from the scatter file of AdBun-M066 (tmpm066fwug.sct).

As per scatter file of AdBun-M066,
initial stack pointer = 0x200000C0 + 0x4000 : 0x200040C0 (which is beyond the RAM of AdBun-M066)

So, Stack pointer must be initialized to =
RAM starting address + Size of RAM = 0x20000000 + 0x4000 (16KB)

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[ ] Feature update (New feature / Functionality change / New API)
[ ] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[ ] Covered by existing mbed-os tests (Greentea or Unittest)
[ ] Tests / results supplied as part of this PR

Reviewers

@0xc0170

Linker issue:
Stack pointer = RAM starting address + Size of RAM = 0x20000000 + 0x4000
@ciarmcom
Copy link
Member

ciarmcom commented Sep 9, 2020

@deepak-shreshti, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from 0xc0170 and a team September 9, 2020 03:00
@mergify mergify bot added needs: CI and removed needs: review labels Sep 10, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2020

We will start CI after we complete the next 6.x release (or if the CI queue allows, earlier).

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 4c3155a into ARMmbed:mbed-os-5.15 Sep 29, 2020
@mergify mergify bot removed the ready for merge label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants