Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mbed CoAP to v5.1.7 #13606

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

teetak01
Copy link
Contributor

Summary of changes

Update Mbed CoAP to v5.1.7.

  • Removed comparison of IP addresses when validating message resending. This avoids unnessary network errors due to load balancers causing frequent IP address changes.
  • Multiple fixes for out-ouf-bounds memory accesses, a memory leak and an infinite loop condition in packet parser.
  • Mapped MBED_CONF_MBED_CLIENT_RECONNECTION_COUNT Pelion Device Management Client configuration option to SN_COAP_RESENDING_MAX_COUNT in mbed-coap.
  • Fix the token from blockwise ACK message to be empty if the received message doesn't have one.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@yogpan01 @anttiylitokola

@yogpan01
Copy link
Contributor

@0xc0170 This fixes logical issues for PDMC when running with mbedOS 5.15 release branch versions. Please take this in the branch.

@ciarmcom
Copy link
Member

@teetak01, thank you for your changes.
@yogpan01 @anttiylitokola @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 15, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2020

I'l lrestart the entire pipeline latest tomorrow morning

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 33dbb27 into ARMmbed:mbed-os-5.15 Oct 13, 2020
@mergify mergify bot removed the ready for merge label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants