Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K82F, KL82Z: Fix the I2C SDK driver slave transfer #13661

Merged
merged 1 commit into from
Sep 30, 2020
Merged

K82F, KL82Z: Fix the I2C SDK driver slave transfer #13661

merged 1 commit into from
Sep 30, 2020

Conversation

MartinBielik
Copy link

In case of slave transfer we dont want the slave to perform stop signal.

Signed-off-by: Bielik [email protected]

Summary of changes

If multiple bytes are send from slave to master, slave is wrongly performing stop signal what brakes communication for 11ms because bus is still active. Slave shouldn't do any Start or Stop signal

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MartinBielik
K82F, KL82Z: Fix the I2C SDK driver slave transfer
d58616d 
In case of slave transfer we dont want the slave to perform stop signal.

Signed-off-by: Bielik <[email protected]>
@ciarmcom ciarmcom requested a review from a team September 24, 2020 09:30
@ciarmcom
Copy link
Member

@MartinBielik, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team September 24, 2020 15:47
0xc0170
0xc0170 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me but would like someone from @ARMmbed/team-nxp to confirm as it's their driver

@mergify mergify bot added needs: CI and removed needs: review labels Sep 29, 2020
@maclobdell
Copy link
Contributor

@mmahadevan108 can you review?

mmahadevan108
mmahadevan108 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

andypowers
andypowers approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 49bd70b into ARMmbed:mbed-os-5.15 Sep 30, 2020
@mergify mergify bot removed the ready for merge label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MartinBielik @ciarmcom @maclobdell @0xc0170 @mbed-ci @mmahadevan108 @andypowers