-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuvoton: Fix NuMaker I2C timeout #13679
Conversation
@cyliangtw, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add details to the commit message how is this fixing (was 0xffffff causing an issue on the bus , what was it?)
some H/W timer count is 24 bits only, hardcode 0xffffffff causing wrong judgement of timeout as while H/W timer counting overflow.
1553c7a
to
ffee35a
Compare
Pull request has been modified.
@0xc0170 , I added more details to this commit message. As while H/W timer counting overflow, it will encounter i2c fake time out and impact i2c application. |
Can you review gitattributetest, something isn ot correct. running |
Pull request has been modified.
One thought: shouldn't we use |
CI started |
@0xc0170 , ticker_read_us() is upper layer API and need critical section overhead. us_ticker_read() is low level API and could get more efficiency. Anyway, these 2 ways could achieve the same goal. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
This PR is to fix I2C timeout measurement for NuMaker platforms instead of hardcode max timer count.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers