Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-os-5.15: Add certificate remove before add to wisun tasklet #13736

Merged
merged 1 commit into from
Oct 22, 2020
Merged

mbed-os-5.15: Add certificate remove before add to wisun tasklet #13736

merged 1 commit into from
Oct 22, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

This prevents tasklet from adding own certificates multiple times to Nanostack in case bootstrap is made again.

This is mbed-os-5.15 version of #13608

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin

Added certificate remove before add to wisun tasklet
c78f17f 
This prevents tasklet from adding own certificates multiple times
to Nanostack in case bootstrap is made again.
@mergify mergify bot added the needs: CI label Oct 8, 2020
@andypowers andypowers self-requested a review October 12, 2020 15:24
andypowers
andypowers approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 changed the title [mbed-os-5.15] Added certificate remove before add to wisun tasklet mbed-os-5.15: Add certificate remove before add to wisun tasklet Oct 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@mergify mergify bot added needs: work and removed needs: CI labels Oct 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2020

CI restarted

@mergify mergify bot added needs: work and removed needs: CI labels Oct 14, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 14, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit ef23563 into ARMmbed:mbed-os-5.15 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@artokin artokin artokin approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikaleppanen @0xc0170 @mbed-ci @artokin @andypowers