Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2354: Upgrade to BSP v3.00.001 (5.15) #13770

Merged
merged 4 commits into from
Oct 30, 2020
Merged

M2354: Upgrade to BSP v3.00.001 (5.15) #13770

merged 4 commits into from
Oct 30, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Oct 16, 2020

Summary of changes

This PR upgrades BSP to v3.00.001 to support MP chip.

Impact of changes

NuMaker-M2354 Ver 1.0 (test chip) gets unsupported. This doesn't do big impact because it is internal only. NuMaker-M2354 Ver 1.1 (MP chip) will be the official one with this upgrade.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
M2354: Remove flash_read override originally for test chip
73614ea 
In test chip, byte-read (LDRB) last byte of flash in non-secure world always gets 0xFF.
This is got around by overriding flash_read(...). Now, the override can remove in MP chip.
@ccli8
M2354: Update to BSP v3.00.001
76463fe 
1.  Change to support MP chip. Original M2355 BSP is for test chip.
2.  UART0, used for USB VCOM, has change in clock enable bit. So chip/board version and BSP version must match.
3.  Remove TF-M legacy code.
@ccli8
M2354: Enable fault handler dump message
260fc30
@ccli8
M2354: Update pre-built non-PSA secure library/image
2acb3a4 
1.  Upgrade to BSP v3.00.001 for MP chip
2.  Enable fault handler dump message
@ciarmcom ciarmcom requested a review from a team October 16, 2020 06:30
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 19, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Oct 21, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 21, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2020

I'll restart the CI (client test failure)

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

andypowers
andypowers approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 4f69795 into ARMmbed:mbed-os-5.15 Oct 30, 2020
@mergify mergify bot removed the ready for merge label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @andypowers