-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SPI NAND Block device driver #14397
Conversation
@rogeryou, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove targets.json patch
targets/targets.json
Outdated
@@ -3832,7 +3832,7 @@ | |||
"MX25LM51245G" | |||
], | |||
"components_add": [ | |||
"OSPIF" | |||
"SPINAND" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think default DISCO_L4R9I is supporting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, default DISCO_L4R9I is not supporting this. I will remove it.
But, I modify this because I tested this driver on DISCO_L4R9I.
So far, there is not any board contained SPI NAND Flash which is supported by mbed os. I replaced the default Flash with SPI NAND Flash MX31LF4GE4BC on DISCO_L4R9I.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could play with your local mbed_app.json file :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
storage/blockdevice/COMPONENT_SPINAND/include/SPINAND/SPINANDBlockDevice.h
Outdated
Show resolved
Hide resolved
Modify astyle
Modify astyle
@0xc0170 @adbridge |
@rogeryou mmm can't see why this is failing on Travis. I'll try closing and re-opening the PR and forcing a fresh run that way. |
@wernerlewis please rereview |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Waiting for final approvals |
This pull request has automatically been marked as stale because it has had no recent activity. , please complete review of the changes to move the PR forward. Thank you for your contributions. |
Summary of changes
Add SPI NAND block device driver for using SPI NAND Flash like Macronix Flash MX31LF4GE4BC.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
This driver is tested on DISCO_L4R9I. The flash on this board is MX31LF4GE4BC. You need to replace it with MX31LF4GE4BC.
Reviewers