Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M487: Fix crash on WDT reset from power-down (5.15) #14502

Merged
merged 1 commit into from
May 18, 2021
Merged

M487: Fix crash on WDT reset from power-down (5.15) #14502

merged 1 commit into from
May 18, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 6, 2021 •
edited
Loading

Summary of changes

This PR is backport of #12557 and #14524 to mbed-os 5.15 and tries to fix issue with WDT reset from power-down mode.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ciarmcom ciarmcom requested a review from a team April 6, 2021 08:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 6, 2021

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Apr 6, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Apr 6, 2021
@mbed-ci
Copy link

mbed-ci commented Apr 8, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@mergify mergify bot dismissed 0xc0170’s stale review April 9, 2021 03:18

Pull request has been modified.

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 9, 2021

Change to backport #12557 and #14524 meanwhile because they are to address the same issue.

0xc0170
0xc0170 previously approved these changes Apr 9, 2021
View reviewed changes
@mergify mergify bot added the needs: CI label Apr 9, 2021
@ccli8
Copy link
Contributor Author

ccli8 commented Apr 15, 2021

Update?

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 21, 2021

Halt this PR. There will be another resolution to this issue.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 21, 2021

Set to needs: work

@ccli8 ccli8 force-pushed the nuvoton_m487_wdt_reset_from_powerdown_5.15 branch from 5fa361a to 08dc5c5 Compare April 22, 2021 03:37
@mergify mergify bot dismissed 0xc0170’s stale review April 22, 2021 03:38

Pull request has been modified.

@ccli8 ccli8 force-pushed the nuvoton_m487_wdt_reset_from_powerdown_5.15 branch from 08dc5c5 to 962c161 Compare April 22, 2021 03:54
@ccli8
Copy link
Contributor Author

ccli8 commented Apr 22, 2021

Set to needs: work

Resume this PR @0xc0170

@ccli8 ccli8 force-pushed the nuvoton_m487_wdt_reset_from_powerdown_5.15 branch from 962c161 to 88b6d19 Compare April 22, 2021 07:57
@ccli8
M487: Get around h/w limit with WDT reset from PD
cb3a678 
Use WKT to get around this h/w limit
@ccli8 ccli8 force-pushed the nuvoton_m487_wdt_reset_from_powerdown_5.15 branch from 88b6d19 to cb3a678 Compare April 22, 2021 11:09
@ccli8
Copy link
Contributor Author

ccli8 commented Apr 23, 2021

@0xc0170 Update done. Please continue with this PR.

@0xc0170 0xc0170 requested a review from andypowers April 26, 2021 12:01
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

@ciarmcom ciarmcom added the stale Stale Pull Request label May 10, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

andypowers
andypowers approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 769fc9d into ARMmbed:mbed-os-5.15 May 18, 2021
@mergify mergify bot removed the ready for merge label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @ciarmcom @mbed-ci @0xc0170 @andypowers