Add bare metal support to Renesas targets #14561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ files were excluded from target_sources, this meant that those files were being missed entirely during the build process. This adds any files that may have missed in the first commit.
mbed-usb (which provides `USBDevice_Types.h`) is a higher-level USB library in Mbed-OS that sits on top of the HAL. Targets should not implement the HAL and use higher-level libraries, hence, the dependency should be removed. This dependency also causes errors when building with the bare-metal profile.
harmut01
requested review from
0xc0170,
RyoheiHagimoto,
TomoYamanaka,
hugueskamba and
LDong-Arm
ciarmcom
added
the
release-type: patch
|
@harmut01, thank you for your changes. |
hugueskamba
approved these changes
Apr 20, 2021
0xc0170
approved these changes
Apr 20, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
USBPhy_RZ_A1.cpp&USBPhy_RZ_A1.cpp:USBDevice_Types.h) is a higher-level USBlibrary in Mbed-OS that sits on top of the HAL. Targets should not
implement the HAL and use higher-level libraries, hence, the dependency
should be removed.
CMakeLists.txt(RZ_A1XX, RZ_A2XX):Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers