create symlink for all sub examples which has mbed-os.lib #14587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@saheerb, thank you for your changes. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
previously requested changes
Apr 26, 2021
tools/test/examples/examples_lib.py
Outdated
| @@ -493,7 +493,17 @@ def symlink_mbedos(config, path, exp_filter): | |||
| for example in config['examples']: | |||
| if example['name'] not in exp_filter: | |||
| continue | |||
| for name in get_sub_examples_list(example): | |||
|
|
|||
| # it's not important that all sub examples are defined in exmaples.json to build | |||
There was a problem hiding this comment.
Suggested change
| # it's not important that all sub examples are defined in exmaples.json to build | |
| # it's not important that all sub examples are defined in examples.json to build |
There was a problem hiding this comment.
I dont understand the comment, what is not important and how this is related what is below?
There was a problem hiding this comment.
I have updated the comment to make the comment in source code simple. The actual reason for change is mentioned in PR description.
mergify
bot
dismissed stale reviews from jamesbeyond and 0xc0170
Pull request has been modified.
0xc0170
approved these changes
Apr 26, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ❌ FAILEDBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is a CI only change. Should have no impact to mbed-os users.
Current CI workflow is:
The symlink creation works only if the sub applications are specified in examples.json. If for whatever reason (experimental, no CI ready etc) a sub examples is not present in example.json, mbed deploy will fetch entire "mbed-os" directory which is obviously a waste of resource.
This PR resolves that by walking through the examples repo and creates symlink if mbed-os.lib is present.
Impact of changes
This is a CI only change. Should have no impact to mbed-os users.
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@jamesbeyond