-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARDUINO_UNO form factor and new PinNames for MIMXRT1050 target #14628
Conversation
Renamed D0..D15 and A0..A5 to ARDUINO_UNO_D0 etc. This allows user to use ARDUINO_UNO as the supported_form_factors in targets.json for MIMXRT1050_EVK.
…Pin Name changes for mbed os v6.10.
@notronrj, thank you for your changes. |
The new Arduino pin naming standard porting guide says the following: All I2C, SPI and UART pin name alias definitions for the Arduino Uno (Rev3) connector pins is defined in the Mbed OS HAL (hal/include/hal/ArduinoUnoAliases.h) and are common to all Arduino Uno compliant targets:
I don't see this file in mbed-os v6.10. In fact, I only see these definitions in the PinNameAliases.h file which is supposed to be removed in the next version of mbed-os. |
Looks like CI build failed due to pinvalidate failing. The report indicates "generic" is failing but "arduino_uno" is passing. Do I need to do anything? |
ARDUINO_UNO_A4 = GPIO_AD_B1_01, | ||
ARDUINO_UNO_A5 = GPIO_AD_B1_00, | ||
|
||
I2C_SCL = ARDUINO_UNO_A5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These I2C_SCL / I2C_SDA pins should be removed as already defined here #14617
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarceloSalazar I will remove those lines. After the update and commit to my fork, will that automatically be seen in this PR? Or must a follow some procedure to update this PR with new commits?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarceloSalazar I will update the PR today. Thanks again.
Thanks @notronrj for the PR. Edit: see docs https://os.mbed.com/docs/mbed-os/v6.10/porting/standard-pin-names.html |
I was about to add a comment why I can't see failures at least
log should contain what has failed (2 messages indicated what is incorrect). can they be added? |
@0xc0170 I think we should add an extra verbose mode in CI, e.g. |
@MarceloSalazar I can make the needed changes. I just want to point out that those LED defines have existed since support for the RT1050 EVK board was added. See this commit My only concern with changing the LED defines is that it could potentially break applications that use them. |
Removed I2C_SCL and I2C_SDA from PinName enum as these are now defined in PinNameAliases.h
@MarceloSalazar @0xc0170 |
@gpsimenos Can you send a new PR? |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
I know it wasn't much of a contribution, but it feels good to have helped out just a little bit. :-) |
Summary of changes
Impact of changes
No real need to change any application code. However using the old Arduino Pin naming standard of D0..D15 etc should now
be changed to use ARDUINO_UNO_D0 .. ARDUINO_UNO_D15 etc. Same for the analog pin names.
Old PinNames such as D0 can continue to be used if desired because of a pin name alias header file:
hal/include/hal/PinNameAliases.h
. However, the next version of mbed-os will not include this alias file.Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers