STM32L152: Added ADC Bank_B functionality #14669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affrinpinhero-2356
changed the title
jeromecoutant
approved these changes
May 17, 2021
|
@affrinpinhero-2356, thank you for your changes. |
jeromecoutant
approved these changes
May 17, 2021
jeromecoutant
suggested changes
May 17, 2021
targets/TARGET_STM/PinNamesTypes.h
Outdated
| @@ -82,6 +82,10 @@ extern "C" { | |||
| #define STM_PIN_AN_CTRL_SHIFT 20 | |||
| #define STM_PIN_ANALOG_CONTROL_BIT (STM_PIN_AN_CTRL_MASK << STM_PIN_AN_CTRL_SHIFT) | |||
|
|
|||
| #define STM_PIN_AN_CHAN_BANK_B_MASK 0x01 | |||
| #define STM_PIN_AN_CHAN_BANK_B_SHIFT 22 | |||
There was a problem hiding this comment.
Please update the beginning of this file (line 50)
PS: why bit 22 is used and not 21 ? :-)
There was a problem hiding this comment.
Corrected and Updated line 50.
affrinpinhero-2356
force-pushed
the
adcBank
branch
from
6d393c2
to
8fe784d
Compare
jeromecoutant
approved these changes
May 18, 2021
| * [18] Inverted (Analog/Timer specific) | ||
| * [19] Analog ADC control - Only valid for specific families | ||
| * [32:21] Reserved | ||
| * [19] Inverted (Analog/Timer specific) |
0xc0170
previously approved these changes
May 18, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
@affrinpinhero-2356 you have modified the PR template and changed it's format, could you please correct it. |
affrinpinhero-2356
force-pushed
the
adcBank
branch
from
8fe784d
to
efdc2d8
Compare
Corrected. |
affrinpinhero-2356
force-pushed
the
adcBank
branch
from
efdc2d8
to
6b7cfc0
Compare
Modified analogin_init function to take correct value for ChannelsBank depends on ADC pin. This commit adds ADC Bank_B usablity to STm32L152RE. With this commit PB_2 can also woak as ADC_IN.
affrinpinhero-2356
force-pushed
the
adcBank
branch
from
6b7cfc0
to
0c9523a
Compare
affrinpinhero-2356
changed the title
I'm afraid you haven't. See this one for how it should look: |
|
@adbridge template looks good! |
|
Is this good to start CI. |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jun 2, 2021
mergify
bot
added
release version missing
|
This PR does not contain release version label after merging. |
0xc0170
added
release-type: patch
affrinpinhero-2356
added a commit
to affrinpinhero-2356/mbed-os
that referenced
this pull request
Jun 2, 2021
Modified print_adc function to update adc pin_map. This patch will update python script that generate 'peripheralPin.c'. Which will give functionality to gernerate ADC pin definition for BANK_B. This commit is related to ARMmbed#14669. fix: * https://github.com/STM32-OSF/mbed-os/issues/3 Signed-off-by: Affrin Pinhero <[email protected]>
affrinpinhero-2356
added a commit
to affrinpinhero-2356/mbed-os
that referenced
this pull request
Jun 2, 2021
Modified print_adc function to update adc pin_map. This patch will update python script that generate 'peripheralPin.c'. Which will give functionality to gernerate ADC pin definition for BANK_B. This script update is related to ARMmbed#14669 Signed-off-by: Affrin Pinhero <[email protected]>
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Modified analogin_init function to take correct value for ChannelsBank depends on ADC pin.
This commit adds ADC Bank_B usablity to STm32L152RE. With this commit PB_2 can also woak as ADC_IN.
Impact of changes
Migration actions required
Documentation
Pull request type:
[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)
Test results:
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR