Fix frozen tools check never failing #14705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@LDong-Arm, thank you for your changes. |
LDong-Arm
changed the title
We only compare files in current PR with the base branch. There's no need to fetch the full git history or branches that are not involved in the comparison. This is to save time in Travis runs.
LDong-Arm
force-pushed
the
frozen_files_fix
branch
from
4ce15cf
to
3b515b3
Compare
Having recently moved the frozen tools check to a standalone stage at the end, we need to fetch the base branch so make comparison work. Travis environments are not shared across different stages. Without the fetch, the check always passes as a PR is compared with itself.
The filter `--diff-filter=d' causes deleted files to be ignored from the frozen tools check. But there is no reason for this, as deleting a file can break compatibility with the legacy tools.
LDong-Arm
force-pushed
the
frozen_files_fix
branch
from
3b515b3
to
a1d1d55
Compare
LDong-Arm
changed the title
Patater
reviewed
May 26, 2021
|
@LDong-Arm, thank you for your changes. |
LDong-Arm
force-pushed
the
frozen_files_fix
branch
from
a1d1d55
to
e31f2bb
Compare
|
Now ready for review. I've removed the experimental commit. Frozen tools check failed as expected when the experimental commit was there. |
|
CI started |
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Having recently moved the frozen tools check to a standalone Travis stage at the end, we need to fetch the base branch so make comparison work. Travis environments are not shared across different stages. Without the fetch, the check always passes as a PR is compared with itself.
Also change
git fetchto be shallow, as the git history is irrelevant togit diffwhich only compares files between two revisions.And deleted files are no longer ignored from the frozen tools check, because deleting a file can also break compatibility with the legacy tools.
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers