-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2354: Substitute HIRC for HXT to clock PLL #14739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bug report of GNU Arm Embedded Toolchain 10-2020-q4-major in CMSE support
These files are refactored on TF-M and make no logic change on Mbed.
1. Build TF-M v1.3 with GNUARM and HXT not present. 2. Support configurability of HXT presence (targets.json). 3. Default HXT to not present (targets.json). This must align with built TF-M secure code above.
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Jun 7, 2021
@ccli8, thank you for your changes. |
0xc0170
approved these changes
Jun 7, 2021
@@ -75,7 +75,7 @@ To define memory spec of SRAM for TF-M/Mbed, search/change the line: | |||
Navigate [TF-M](https://www.trustedfirmware.org/projects/tf-m/). | |||
Then go through **DOCS** → **Getting Started Guides** → **Software requirements** for TF-M build environment setup. | |||
|
|||
**NOTE**: For unknown reason, **GNU Arm Embedded Toolchain 10-2020-q4-major** built code **FAILS** to run. Avoid this toolchain version. | |||
**NOTE**: **GNU Arm Embedded Toolchain 10-2020-q4-major** built code **FAILS** to run. Avoid this toolchain version. Check [its bug report](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99157). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its fixed now so the next version will have it fixed as well
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR tries to substitute HIRC for HXT to clock PLL. This is to spare one external crystal oscillator HXT. Below list the modifications:
Pull request type
Test results