Correct ufsi timing calculation #14748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating ufsi, the function was relying on the slot processed by the unicast fhss timer callback, which can be delayed. When it happens the slot value is wrong, and the ufsi is incorrect. The ufsi is then used by the peer to determined the reply channel, so the devices are thus unsynchronized until the next uplink packet.
ciarmcom
added
the
release-type: patch
|
@AlbanJeantheau-silabs, thank you for your changes. |
|
@artokin Please review |
JarkkoPaso
reviewed
Jun 9, 2021
connectivity/nanostack/sal-stack-nanostack/source/Service_Libs/fhss/fhss_ws.c
Outdated
Show resolved
Hide resolved
JarkkoPaso
reviewed
Jun 10, 2021
connectivity/nanostack/sal-stack-nanostack/source/Service_Libs/fhss/fhss_ws.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Jarkko Paso <[email protected]>
JarkkoPaso
approved these changes
Jun 11, 2021
0xc0170
approved these changes
Jun 11, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This change fixes UFSI calculation. We have noticed in some circumstances the fhss timer callback can be delayed, wisun devices can lost frequency hopping synchronization.
When calculating ufsi, the function was relying on the slot processed by the unicast fhss timer callback, which can be delayed. When it happens the slot value is wrong, and the ufsi is incorrect.
The ufsi is then used by the peer to determined the reply channel, so the devices are thus unsynchronized until the next uplink packet.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers