Move rtos stubs to the rtos directory #14819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkan01
changed the title
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
|
I added the issue to our project board and removed the PR. We prefer putting the issue onto the board, and it automatically shows the PR that fixes it. |
LDong-Arm
previously approved these changes
Jun 23, 2021
0xc0170
previously approved these changes
Jun 24, 2021
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
The failed files are stubs from unittests, they should not be compiled for cloud examples (I opened build cloud example Gcc Arm for instance) ? |
mergify
bot
dismissed stale reviews from LDong-Arm and 0xc0170
Pull request has been modified.
rajkan01
force-pushed
the
move_rtos_stubs
branch
from
5bf88e0
to
a9c3ea4
Compare
It supposed not to be compiled for cloud example because of newly added the UNITTESTS directory in rtos, so pushed the missing .mbedignore file to fix the issue |
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
LDong-Arm
previously approved these changes
Jun 28, 2021
|
@rajkan01 We can rerun the CI if you squash the last two (fixup commit) |
Move the rtos stub library into the rtos component directory. so we can avoid duplicating the mbed-os source tree in a central UNITTESTS folder.
…ctory Move rtos stubs headers to the mbed-os/rtos/tests/UNITTESTS/double directory and update CMake to create a mbed-stubs-rtos-headers library for rtos stub headers
Move the header-only mbed-headers-rtos library the unit test stubs depend on into the rtos component directory. This makes the rtos stubs more self-contained and improves the composition of the library.
mbed-stubs-connectivity now depends on the mbed-stubs-rtos and mbed-stubs-rtos-headers because it requires some headers and sources which were moved to mbed-stubs-rtos and mbed-stubs-rtos-headers.
rajkan01
force-pushed
the
move_rtos_stubs
branch
from
a9c3ea4
to
8efb322
Compare
|
Ci restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
LDong-Arm
approved these changes
Jun 29, 2021
0xc0170
approved these changes
Jun 30, 2021
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
fixes #14793
This PR makes the mbed-stubs-rtos library more self-contained by removing the dependencies on the monolithic header libraries we created to make implementing the stubs easier. We also move the files to the rtos directory so the stubs live with the associated component.
Impact of changes
None.
Migration actions required
None
Documentation
To be updated
Pull request type
Test results
Reviewers