Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Pin Name: LED1 issue for targets without LED #14881

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

3 patches:

  • generic_tests is now compatible with for targets without LED1
  • events-timing test should not need any LED
  • pin_names-generic test is now compatible with more targets

@MarceloSalazar

Impact of changes

MBED can support targets with or without LED and with or without BUTTON

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@jeromecoutant jeromecoutant changed the title Standard Pin Name: LED1 Standard Pin Name: LED1 issue for targets without LED Jul 6, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 6, 2021
@ciarmcom ciarmcom requested a review from a team July 6, 2021 15:30
@ciarmcom
Copy link
Member

ciarmcom commented Jul 6, 2021

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 6, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 7, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit e145ae3 into ARMmbed:master Jul 7, 2021
@mergify mergify bot removed the ready for merge label Jul 7, 2021
@jeromecoutant jeromecoutant deleted the PR_LED1 branch July 7, 2021 15:55
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants