Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests: storage: Only use headers, sources and definitions needed by each test #14882

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Unit tests: storage: Only use headers, sources and definitions needed by each test #14882

merged 2 commits into from
Jul 7, 2021

Conversation

LDong-Arm
Copy link
Contributor

Summary of changes

This PR is a follow-up of #14862

Clean up CMake definitions of storage unit tests to

  • only depend on headers each test uses
  • remove sources and definitions that are not used by each test

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@rajkan01 @ARMmbed/mbed-os-core

@LDong-Arm
Unit tests: Make storage tests depend explicitly on headers it uses
5c6c08c 
The CMake target `mbed-headers` brings in all headers, and we are
gradually moving away from it and explicitly use only headers needed
by each unit test.
@LDong-Arm LDong-Arm requested a review from rajkan01 July 6, 2021 15:28
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 6, 2021
@ciarmcom ciarmcom requested a review from a team July 6, 2021 15:30
@ciarmcom
Copy link
Member

ciarmcom commented Jul 6, 2021

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@Patater
Copy link
Contributor

Patater commented Jul 7, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jul 7, 2021
@mbed-ci
Copy link

mbed-ci commented Jul 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@Patater Patater merged commit b490c67 into ARMmbed:master Jul 7, 2021
@mergify mergify bot removed the ready for merge label Jul 7, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
component: core release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LDong-Arm @ciarmcom @Patater @mbed-ci @mbedmain