Standard Pin Names validation script update #14939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@jeromecoutant, thank you for your changes. |
0xc0170
previously requested changes
Jul 21, 2021
| @@ -56,7 +56,7 @@ def find_target_by_path(target_path): | |||
|
|
|||
| with open(target_path) as pin_names_file: | |||
| pin_names_file_content = pin_names_file.read() | |||
|
|
|||
There was a problem hiding this comment.
please remove spaces in separate commit
There was a problem hiding this comment.
PyCharm has removed them automatically...
There was a problem hiding this comment.
please remove spaces in separate commit
Done!
jeromecoutant
force-pushed
the
PR_PIN_ALIAS
branch
from
765c186
to
c7d9093
Compare
gpsimenos
previously approved these changes
Jul 21, 2021
hal/tests/pinvalidate/pinvalidate.py
Outdated
| def legacy_arduino_uno_check(arduino_form_factor): | ||
| invalid_items = [] | ||
| if arduino_form_factor == True: | ||
| message = "ARDUINO form factor is deprecated, should be replaced by ARDUIN_UNO" |
There was a problem hiding this comment.
Suggested change
| message = "ARDUINO form factor is deprecated, should be replaced by ARDUIN_UNO" | |
| message = "ARDUINO form factor is deprecated, should be replaced by ARDUINO_UNO" |
0xc0170
previously approved these changes
Jul 21, 2021
|
I'll wait with CI until the typo is fixed. |
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
Goal is to follow hal/include/hal/PinNameAliases.h
jeromecoutant
force-pushed
the
PR_PIN_ALIAS
branch
from
c7d9093
to
97cd8e9
Compare
Done |
mergify
bot
dismissed stale reviews from 0xc0170 and gpsimenos
Pull request has been modified.
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jul 22, 2021
mbedmain
added
release-version: 6.14.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
2 new tests:
check if SPI and I2C alias are well defined as expected by
https://github.com/ARMmbed/mbed-os/blob/master/hal/include/hal/PinNameAliases.h
check if ARDUINO_UNO and not ARDUINO is well used
@gpsimenos @MarceloSalazar
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers