Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions for mbed-os-env docker management #14952

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

saheerb
Copy link
Contributor

@saheerb saheerb commented Jul 22, 2021

Summary of changes

This PR created github action workflow for managing docker environment mbed-os-env (which was previously stored in https://hub.docker.com/repository/docker/mbedos/mbed-os-env)

Documentation provided in this PR explains the design and versioning strategy.

The docker packages will be available in ghcr.io.

Impact of changes

None

Migration actions required

None

Documentation

Design is provided in PR. Usage instructions need to be updated in examples, and mbed-os-doc


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond


@0xc0170 0xc0170 requested a review from a team July 22, 2021 14:44
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 22, 2021
@ciarmcom
Copy link
Member

@saheerb, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. well done!
I left some trivial comments

.github/workflows/docker_management.prune.yml Show resolved Hide resolved
.github/workflows/docker_management.prune.yml Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
jamesbeyond
jamesbeyond previously approved these changes Jul 28, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Jul 28, 2021
.github/workflows/docker_management.test-PR.yml Outdated Show resolved Hide resolved
name: Checkout
uses: actions/checkout@v2
with:
repository: ARMmbed/mbed-os-example-blinky
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it sufficient to test with blinky? should we use more advanced example, cloud example for instance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment for official examples should be same and blinky is our go to application for system tests.

docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
@mergify mergify bot added needs: work and removed needs: CI labels Jul 28, 2021
.github/workflows/ci_scripts/ghcr_utils.py Outdated Show resolved Hide resolved
.github/workflows/ci_scripts/ghcr_utils.py Outdated Show resolved Hide resolved
.github/workflows/ci_scripts/ghcr_utils.py Outdated Show resolved Hide resolved
.github/workflows/ci_scripts/ghcr_utils.py Show resolved Hide resolved
.github/workflows/ci_scripts/ghcr_utils.py Outdated Show resolved Hide resolved
.github/workflows/ci_scripts/ghcr_utils.py Outdated Show resolved Hide resolved
.github/workflows/docker_management.prune.yml Outdated Show resolved Hide resolved
.github/workflows/docker_management.prune.yml Outdated Show resolved Hide resolved
docker_images/mbed-os-env/Dockerfile Outdated Show resolved Hide resolved
docker_images/mbed-os-env/Dockerfile Show resolved Hide resolved
docker_images/mbed-os-env/Dockerfile Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed stale reviews from jamesbeyond, 0xc0170, rwalton-arm, and Patater July 30, 2021 12:03

Pull request has been modified.

Patater
Patater previously requested changes Aug 2, 2021
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/Dockerfile Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Patater’s stale review August 2, 2021 14:53

Pull request has been modified.

Patater
Patater previously requested changes Aug 3, 2021
docker_images/mbed-os-env/README.md Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Patater’s stale review August 3, 2021 12:38

Pull request has been modified.

Patater
Patater previously requested changes Aug 3, 2021
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Patater’s stale review August 3, 2021 13:42

Pull request has been modified.

Patater
Patater previously requested changes Aug 3, 2021
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
@saheerb
Copy link
Contributor Author

saheerb commented Aug 3, 2021

@ChrisGooch-Arm could you please review the read me as well?

Patater
Patater previously requested changes Aug 3, 2021
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docker_images/mbed-os-env/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
docs/design-documents/docker_management/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Chris can take a look afterwards and raise a new PR with fixes as needed.

@Patater
Copy link
Contributor

Patater commented Aug 3, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 3, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 06c9799 into ARMmbed:master Aug 4, 2021
@mergify mergify bot removed the ready for merge label Aug 4, 2021
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants