-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions for mbed-os-env docker management #14952
Conversation
@saheerb, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. well done!
I left some trivial comments
name: Checkout | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: ARMmbed/mbed-os-example-blinky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it sufficient to test with blinky? should we use more advanced example, cloud example for instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
environment for official examples should be same and blinky is our go to application for system tests.
Pull request has been modified.
@ChrisGooch-Arm could you please review the read me as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Chris can take a look afterwards and raise a new PR with fixes as needed.
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
This PR created github action workflow for managing docker environment mbed-os-env (which was previously stored in https://hub.docker.com/repository/docker/mbedos/mbed-os-env)
Documentation provided in this PR explains the design and versioning strategy.
The docker packages will be available in ghcr.io.
Impact of changes
None
Migration actions required
None
Documentation
Design is provided in PR. Usage instructions need to be updated in examples, and mbed-os-doc
Pull request type
Test results
Reviewers
@jamesbeyond