Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis ci migration to github action #14995

Merged
merged 1 commit into from
Aug 12, 2021
Merged

travis ci migration to github action #14995

merged 1 commit into from
Aug 12, 2021

Conversation

saheerb
Copy link
Contributor

@saheerb saheerb commented Aug 11, 2021

Summary of changes

mbed-os is migration basic CI checks currently done in Travis CI as Travis is not free anymore. This is a Draft PR to get some feedback on GiHub Action migration from travsi CI.

Testing is currently ongoing with this PR.

Impact of changes

No user impacted changes.

Migration actions required

Once merged in we shall disable CI for "mbed-os" from travis side.

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond


@saheerb saheerb requested a review from 0xc0170 August 11, 2021 10:22
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 11, 2021
@ciarmcom
Copy link
Member

@saheerb, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-maintainers please review.

.github/workflows/basic_checks.yml Show resolved Hide resolved
@@ -1,213 +0,0 @@
#!/bin/bash -euf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was completely removed, the functionality is already provided (or was anything ported from this script) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this is no longer required as installation of gcc etc in directly in docker image. rest is replaced by apt install as needed.

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater
Copy link
Contributor

Patater commented Aug 11, 2021

CI started.

We don't expect results to be reported for Travis, as this PR removes .travis.yml.

@mbed-ci
Copy link

mbed-ci commented Aug 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@Patater Patater requested a review from 0xc0170 August 11, 2021 15:58
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2021

I removed travis required check for master, I'll merge this in now.

@0xc0170 0xc0170 merged commit 68667df into ARMmbed:master Aug 12, 2021
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants