Add missing include for PinNames.h #15002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@ladislas, thank you for your changes. |
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Aug 13, 2021
As described in ARMmbed/mbed-os#15002 there is a missing include for PinNames.h in InterfaceDigitalIn.h The mbed version and url has been updated to pull a fix from a fork branch. This should be reverted when ARMmbed/mbed-os#15002 is merged.
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Aug 13, 2021
As described in ARMmbed/mbed-os#15002 there is a missing include for PinNames.h in InterfaceDigitalIn.h The mbed version and url has been updated to pull a fix from a fork branch. This should be reverted when ARMmbed/mbed-os#15002 is merged.
0xc0170
approved these changes
Aug 16, 2021
|
CI started |
|
@0xc0170 could this be released as a hotfix as 6.13.1? |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
There's code freeze for upcoming release today (monthly cadence), it will be 6.14 as there were some feature PRs merged. |
|
Test failure is not related, I can see it failed similarly in other PRs, we will check. |
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add missing include for
PinNames.h.Impact of changes
Fixes compilation issues when using
interface::DigitalInMigration actions required
n/a
Documentation
n/a
Pull request type
Test results
Reviewers
@0xc0170 @AGlass0fMilk